Merge pull request #289 from ukalifon/download-with-chrome

Download with Chrome

Author: rawagner

Diff for: cypress/integration-qe/e2e-createNewCluster.spec.js

@@ -1,4 +1,11 @@
-import { CLUSTER_NAME, PULL_SECRET, SSH_PUB_KEY, createCluster, generateIso } from './shared';
+import {
+  CLUSTER_NAME,
+  PULL_SECRET,
+  SSH_PUB_KEY,
+  createCluster,
+  generateIso,
+  downloadFileWithChrome,
+} from './shared';
 
 describe('Flow', () => {
   it('start from the /clusters page', () => {
@@ -14,4 +21,12 @@ describe('Flow', () => {
   it('generate the ISO', () => {
     generateIso(SSH_PUB_KEY);
   });
+
+  it('download the ISO', () => {
+    cy.get('#button-download-discovery-iso').click(); // open the dialog
+    cy.get('.pf-c-modal-box__footer > .pf-m-primary').click(); // "Get Discovery ISO"
+    downloadFileWithChrome('button[data-test-id="download-iso-btn"]', ' ~/Downloads/cluster-*.iso');
+    cy.get('button[data-test-id="close-iso-btn"]').click(); // now close the dialog
+    cy.exec('mv -f ~/Downloads/cluster-*.iso /var/lib/libvirt/images/cluster-discovery.iso');
+  });
 });

Diff for: cypress/integration-qe/e2e-enterClusterSpecs.spec.js

@@ -9,6 +9,7 @@ import {
   openCluster,
   startClusterInstallation,
   waitForClusterInstallation,
+  downloadFileWithChrome,
 } from './shared';
 
 import {
@@ -104,3 +105,13 @@ describe('Run install', () => {
     waitForClusterInstallation();
   });
 });
+
+describe('Donwload kubeconfig', () => {
+  it('download kubeconfig', () => {
+    downloadFileWithChrome(
+      'div.pf-l-grid__item > button.pf-c-button.pf-m-secondary',
+      '~/Downloads/kubeconfig',
+    );
+    cy.exec('mv -f ~/Downloads/kubeconfig ~');
+  });
+});

Diff for: cypress/integration/constants.js

@@ -8,5 +8,9 @@ export const HOST_DISCOVERY_TIMEOUT = 30 * 1000;
 export const VALIDATE_CHANGES_TIMEOUT = 10 * 1000;
 // timeout for install preparation - 1 minute
 export const INSTALL_PREPARATION_TIMEOUT = 60 * 1000;
+// timeout for generating ISO
+export const GENERATE_ISO_TIMEOUT = 2 * 60 * 1000;
+// timeout for downloading files (such as ISO images)
+export const FILE_DOWNLOAD_TIMEOUT = 10 * 60 * 1000;
 // timeout for cluster instation to finish - 1 hour
 export const CLUSTER_CREATION_TIMEOUT = 60 * 60 * 1000;

Diff for: cypress/integration/shared.js

@@ -5,6 +5,7 @@ import {
   CLUSTER_CREATION_TIMEOUT,
   HOST_DISCOVERY_TIMEOUT,
   HOST_REGISTRATION_TIMEOUT,
+  FILE_DOWNLOAD_TIMEOUT,
 } from './constants';
 
 export const testInfraClusterName = 'test-infra-cluster';
@@ -127,7 +128,8 @@ export const generateIso = (sshPubKey) => {
   cy.get('.pf-c-modal-box__footer > .pf-m-primary').click();
   // cy.get('.pf-c-modal-box__footer > .pf-m-primary', { timeout: 5 * 60 * 1000 });
   // bug: cy.get() timeout is ignored since former inner XHR is aborted by Cypress
-  cy.wait(90 * 1000).then(() => {
+  // using constant GENERATE_ISO_TIMEOUT causes a lint crash https://github.com/cypress-io/eslint-plugin-cypress/issues/43
+  cy.wait(2 * 60 * 1000).then(() => {
     // yield potentially onAnyAbort()
     if (aborted) {
       cy.log('Long-running XHR was aborted');
@@ -139,9 +141,30 @@ export const generateIso = (sshPubKey) => {
     } else {
       cy.log('Waiting for ISO was successful');
     }
-    cy.get('.pf-c-modal-box__footer > .pf-m-primary').contains('Download Discovery ISO');
   });
-  cy.get('#pf-modal-part-7 > footer > button.pf-c-button.pf-m-secondary').click(); // now close the dialog
+  cy.get('button[data-test-id="download-iso-btn"]', { timeout: 2 * 60 * 1000 }).contains(
+    'Download Discovery ISO',
+  );
+  cy.get('button[data-test-id="close-iso-btn"]').click(); // now close the dialog
+};
+
+export const downloadFileWithChrome = (downloadButton, resultantFilename) => {
+  // NOTE: This works only with Chrome, where the default behavior is:
+  //  1) It starts the download without popping up a save dialog (which would require automating native windows)
+  //  2) It caches to a temporary location, and when the download is complete it moves the file to ~/Downloads
+
+  // first delete old downloads
+  cy.exec(`[ -f ${resultantFilename} ] && rm -rf ${resultantFilename}`, {
+    failOnNonZeroExit: false,
+  });
+  cy.get(downloadButton).click();
+
+  // wait until the file shows up, to know that the download finshed
+  cy.exec(`while [ ! -f ${resultantFilename} ]; do sleep 1; done`, {
+    timeout: FILE_DOWNLOAD_TIMEOUT,
+  }).should((result) => {
+    expect(result.code).to.be.eq(0);
+  });
 };
 
 export const assertTestClusterPresence = (cy) => {