-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add security scan #114
Merged
rccrdpccl
merged 1 commit into
openshift-assisted:master
from
rccrdpccl:add-security-scan
Mar 31, 2025
Merged
add security scan #114
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| name: security-scan | ||
| on: | ||
| push: | ||
| branches: | ||
| - master | ||
| pull_request: | ||
| jobs: | ||
| build: | ||
| name: Security scan | ||
| runs-on: ubuntu-24.04 | ||
| env: | ||
| CONTAINER_TAG: ${{ github.sha }} | ||
| CONTAINER_TOOL: docker | ||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
| - name: Build images from Dockerfile | ||
| run: make docker-build-all | ||
| - name: Create scans folder | ||
| run: | | ||
| mkdir -p scans/ | ||
| - name: Run Trivy vulnerability scanner for controlplane | ||
| uses: aquasecurity/trivy-action@0.30.0 | ||
| with: | ||
| image-ref: 'quay.io/edge-infrastructure/cluster-api-controlplane-provider-openshift-assisted:${{ github.sha }}' | ||
| trivy-config: .trivy.yaml | ||
| output: 'scans/trivy-results-controlplane.sarif' | ||
| - name: Run Trivy vulnerability scanner for bootstrap | ||
| uses: aquasecurity/trivy-action@0.30.0 | ||
| with: | ||
| image-ref: 'quay.io/edge-infrastructure/cluster-api-bootstrap-provider-openshift-assisted:${{ github.sha }}' | ||
| trivy-config: .trivy.yaml | ||
| output: 'scans/trivy-results-bootstrap.sarif' | ||
| - name: Run Trivy vulnerability scanner in repo mode | ||
| uses: aquasecurity/trivy-action@0.30.0 | ||
| with: | ||
| scan-type: 'fs' | ||
| output: 'trivy-results-repo.sarif' | ||
| - name: Upload Trivy scan results to GitHub Security tab | ||
| uses: github/codeql-action/upload-sarif@v3 | ||
| if: always() | ||
| with: | ||
| sarif_file: 'scans/' | ||
coderabbitai[bot] marked this conversation as resolved.
Show resolved
Hide resolved
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| scan: | ||
| offline: true | ||
| vulnerability: | ||
| ignore-unfixed: true | ||
| severity: | ||
| - HIGH | ||
| - CRITICAL | ||
| format: 'sarif' | ||
| pkg: | ||
| types: | ||
| - os | ||
| - library |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Review Output Location for Repo Mode Scan
The "Run Trivy vulnerability scanner in repo mode" step outputs its results to
trivy-results-repo.sarif(line 38), which is outside thescans/folder. Since the subsequent upload step uses the patternscans/*.sarif, this file may be omitted from the upload. It is recommended to change the output path toscans/trivy-results-repo.sariffor consistency and to ensure all scan results are captured.Proposed Diff:
📝 Committable suggestion