Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARO-15313: add Cluster.Capabilities.Disabled #1020

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ARO-15313: add Cluster.Capabilities.Disabled #1020

wants to merge 1 commit into from
+47 −0

Conversation

sanchezl
Copy link

@sanchezl sanchezl commented Feb 4, 2025 •
edited
Loading

Add Cluster.Capabilities.Disabled field.

@sanchezl sanchezl marked this pull request as ready for review February 5, 2025 16:45
@sanchezl sanchezl force-pushed the image-registry branch 3 times, most recently from fda0a55 to 6d8aeeb Compare February 18, 2025 19:59
@sanchezl sanchezl changed the title add Cluster.DisabledCapabilities add Cluster.Capabilities.Disabled Feb 18, 2025
@sanchezl sanchezl changed the title add Cluster.Capabilities.Disabled ARO-15313: add Cluster.Capabilities.Disabled Feb 18, 2025
@ahitacat
Copy link
Contributor

This looks good so far, but I would expect to have the change in CS.

@sanchezl
Copy link
Author

This looks good so far, but I would expect to have the change in CS.

The Cluster.Capabilities field is optional. We should be able to add it without breaking any existing clients or servers.

@sanchezl sanchezl mentioned this pull request Feb 19, 2025
Draft
@sanchezl
Copy link
Author

Draft of ocm-sdk-go updates: openshift-online/ocm-sdk-go#1029

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanchezl @ahitacat