Skip to content

OAPE-92: Promote RouteExternalCertificate feature gate to default feature set #2268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2025
Merged

OAPE-92: Promote RouteExternalCertificate feature gate to default feature set #2268

merged 1 commit into from
Apr 23, 2025
+9 −2,073

Conversation

chiragkyal
Copy link
Member

@chiragkyal chiragkyal commented Apr 9, 2025 •
edited
Loading

Promote RouteExternalCertificate feature gate to default feature set for both SelfManaged and HyperShift.

@chiragkyal
Promote RouteExternalCertificate feature gate to default feature set
e7ac40f 
Signed-off-by: chiragkyal <ckyal@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 9, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 9, 2025 •
edited by openshift-ci bot
Loading

@chiragkyal: This pull request references OAPE-92 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 9, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 9, 2025

Hello @chiragkyal! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 9, 2025
@openshift-ci openshift-ci bot requested review from everettraven and knobunc April 9, 2025 19:24
@chiragkyal
Copy link
Member Author

/retest

@lihongan
Copy link
Contributor

lihongan commented Apr 15, 2025 •
edited
Loading

@chiragkyal FYI...QE tested the feature on Bare Metal disconnected (ipv4/ipv6/dual) platform and passed.

@chiragkyal
Copy link
Member Author

/retest

@chiragkyal chiragkyal mentioned this pull request Apr 17, 2025
Merged
@chiragkyal
Copy link
Member Author

/test verify-feature-promotion

@chiragkyal
Copy link
Member Author

/retest

@swghosh swghosh mentioned this pull request Apr 21, 2025
Closed
@chiragkyal chiragkyal mentioned this pull request Apr 22, 2025
Closed
@chiragkyal
Copy link
Member Author

/retest

@swghosh
Copy link
Member

swghosh commented Apr 22, 2025

/test e2e-aws-ovn-hypershift-conformance

Re-triggerring as the changes in openshift/hypershift#6060 for the feature gates rendering just landed onto registry.ci.openshift.org/hypershift/hypershift-operator:latest.

@swghosh
Copy link
Member

swghosh commented Apr 22, 2025

/remove-hold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 22, 2025
@JoelSpeed
Copy link
Contributor

/override ci/prow/verify-crd-schema

The failures in the verify are down to a non-structural schema being used for validations. See https://redhat-internal.slack.com/archives/CCH60A77E/p1745332989637839 for a future fix

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 22, 2025

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-crd-schema

In response to this:

/override ci/prow/verify-crd-schema

The failures in the verify are down to a non-structural schema being used for validations. See https://redhat-internal.slack.com/archives/CCH60A77E/p1745332989637839 for a future fix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@swghosh
Copy link
Member

swghosh commented Apr 22, 2025 •
edited
Loading

ci/prow/e2e-aws-ovn-hypershift-conformance had failed because of lack of --feature-gates arg on the openshift-apiserver pod that forms part of the hypershift HostedCluster, openshift/hypershift#6068 fixes this issue by introducing feature gates to the hypershift's o-apiserver pod.

Waiting on registry.ci.openshift.org/hypershift/hypershift-operator:latest to get updated with the new fix, before we can trigger the hypershift-conformance job again.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 22, 2025 •
edited by openshift-ci bot
Loading

@chiragkyal: This pull request references OAPE-92 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Promote RouteExternalCertificate feature gate to default feature set for both SelfManaged and HyperShift.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@swghosh
Copy link
Member

swghosh commented Apr 22, 2025

ci/prow/e2e-aws-ovn-hypershift-conformance had failed because of lack of --feature-gates arg on the openshift-apiserver pod that forms part of the hypershift HostedCluster, openshift/hypershift#6068 fixes this issue by introducing feature gates to the hypershift o-apiserver.

Waiting on registry.ci.openshift.org/hypershift/hypershift-operator:latest to get updated with the new fix, before we can trigger the hypershift-conformance job again.

/test e2e-aws-ovn-hypershift-conformance

changes in openshift/hypershift#6068 are part of registry.ci.openshift.org/hypershift/hypershift-operator:latest now

@chiragkyal
Copy link
Member Author

e2e-aws-ovn-hypershift-conformance ran successfully with the latest changes in openshift/hypershift#6068. There is one testcase failure on HyperShift side for which openshift/origin#29698 is raised and we got the approvals.

Waiting for the bot to merge that PR (tide is taking longer than expected to merge it). I've asked for an override for the permafailing e2e-metal-ipi-ovn-ipv6 job.

@JoelSpeed
Copy link
Contributor

/test e2e-aws-serial-techpreview
/test e2e-aws-ovn-hypershift-conformance

@JoelSpeed
Copy link
Contributor

/test e2e-aws-ovn-hypershift-conformance

@JoelSpeed
Copy link
Contributor

/override ci/prow/verify-feature-promotion

Test runs for those including [skipped:Disconnected] look like we have enough green runs at the right pass rates (tests were renamed so showing some older names)

/lgtm

This is good to go if CI can go green

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chiragkyal, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 23, 2025

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-feature-promotion

In response to this:

/override ci/prow/verify-feature-promotion

Test runs for those including [skipped:Disconnected] look like we have enough green runs at the right pass rates (tests were renamed so showing some older names)

/lgtm

This is good to go if CI can go green

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@chiragkyal
Copy link
Member Author

chiragkyal commented Apr 23, 2025 •
edited
Loading

openshift/origin#29698 changes have just landed in the CI registry. Re-running the hypershift conformance

/test e2e-aws-ovn-hypershift-conformance

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 23, 2025 •
edited
Loading

@chiragkyal: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify-client-go e7ac40f link true /test verify-client-go

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9aa03e6 and 2 for PR HEAD e7ac40f in total

@sdodson sdodson merged commit 29e7c44 into openshift:master Apr 23, 2025
23 of 25 checks passed
@sdodson
Copy link
Member

sdodson commented Apr 23, 2025

Merging to avoid retest loop.

@chiragkyal chiragkyal deleted the promote-routeExternalCertificate branch April 23, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@everettraven everettraven Awaiting requested review from everettraven

@knobunc knobunc Awaiting requested review from knobunc

Assignees

@JoelSpeed JoelSpeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chiragkyal @openshift-ci-robot @lihongan @swghosh @JoelSpeed @sdodson