Skip to content

MGMT-20168: Missing set_infraenv_version in skipper.env #2677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2025

Conversation

CrystalChun
Copy link
Contributor

Missed initializing this variable here in the original PR #2670
/cc @danmanor

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 5, 2025
@openshift-ci openshift-ci bot requested a review from danmanor May 5, 2025 22:27
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 5, 2025

@CrystalChun: This pull request references MGMT-20168 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

In response to this:

Missed initializing this variable here in the original PR #2670
/cc @danmanor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 5, 2025
@CrystalChun
Copy link
Contributor Author

/retest

@CrystalChun CrystalChun force-pushed the fix-sno-4.18-test branch from f990f6f to 4fd6b3b Compare May 9, 2025 21:23
@CrystalChun
Copy link
Contributor Author

CrystalChun commented May 9, 2025

/retitle MGMT-20168: Missing set_infraenv_version in skipper.env

@openshift-ci openshift-ci bot changed the title MGMT-20168: Missing set_infraenv_version initialization MGMT-20168: Missing set_infraenv_version in skipper.env May 9, 2025
Copy link

openshift-ci bot commented May 9, 2025

@CrystalChun: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 11, 2025
Copy link

openshift-ci bot commented May 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CrystalChun, danmanor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 86fd6a2 into openshift:master May 11, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants