Skip to content

Commit eafea57

Browse files
openshift-merge-bot[bot]openshift-merge-bot[bot]
authored
Merge pull request #5896 from bryan-cox/delete-role-assignment
CNTRLPLANE-366: Create Azure role assignments in the Azure HC CLI
2 parents cbbfe1d + 3c22356 commit eafea57

File tree

64 files changed

+11360
-695
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

64 files changed

+11360
-695
lines changed

‎api/hypershift/v1beta1/azure.go

+2-3
Original file line numberDiff line numberDiff line change
@@ -461,9 +461,8 @@ type AzureResourceManagedIdentities struct {
461461
// ManagedIdentity contains the client ID, and its certificate name, of a managed identity. This managed identity is
462462
// used, by an HCP component, to authenticate with the Azure API.
463463
type ManagedIdentity struct {
464-
// clientID is the client ID of a managed identity.
465-
// Deprecated: This field was previously required as part of the MIWI phase 2 work; however, this field will be
466-
// removed as part of the MIWI phase 3 work, https://issues.redhat.com/browse/OCPSTRAT-1856.
464+
// clientID is the client ID of a managed identity associated with CredentialsSecretName. This field is optional and
465+
// mainly used for CI purposes.
467466
//
468467
// +optional
469468
// +kubebuilder:validation:XValidation:rule="self.matches('^[{]?[0-9a-fA-F]{8}-([0-9a-fA-F]{4}-){3}[0-9a-fA-F]{12}[}]?$')",message="the client ID of a managed identity must be a valid UUID. It should be 5 groups of hyphen separated hexadecimal characters in the form 8-4-4-4-12."

‎api/hypershift/v1beta1/zz_generated.featuregated-crd-manifests/hostedclusters.hypershift.openshift.io/AAA_ungated.yaml

+18-27
Original file line numberDiff line numberDiff line change
@@ -3103,9 +3103,8 @@ spec:
31033103
type: string
31043104
clientID:
31053105
description: |-
3106-
clientID is the client ID of a managed identity.
3107-
Deprecated: This field was previously required as part of the MIWI phase 2 work; however, this field will be
3108-
removed as part of the MIWI phase 3 work, https://issues.redhat.com/browse/OCPSTRAT-1856.
3106+
clientID is the client ID of a managed identity associated with CredentialsSecretName. This field is optional and
3107+
mainly used for CI purposes.
31093108
type: string
31103109
x-kubernetes-validations:
31113110
- message: the client ID of a managed identity
@@ -3164,9 +3163,8 @@ spec:
31643163
type: string
31653164
clientID:
31663165
description: |-
3167-
clientID is the client ID of a managed identity.
3168-
Deprecated: This field was previously required as part of the MIWI phase 2 work; however, this field will be
3169-
removed as part of the MIWI phase 3 work, https://issues.redhat.com/browse/OCPSTRAT-1856.
3166+
clientID is the client ID of a managed identity associated with CredentialsSecretName. This field is optional and
3167+
mainly used for CI purposes.
31703168
type: string
31713169
x-kubernetes-validations:
31723170
- message: the client ID of a managed identity
@@ -3224,9 +3222,8 @@ spec:
32243222
type: string
32253223
clientID:
32263224
description: |-
3227-
clientID is the client ID of a managed identity.
3228-
Deprecated: This field was previously required as part of the MIWI phase 2 work; however, this field will be
3229-
removed as part of the MIWI phase 3 work, https://issues.redhat.com/browse/OCPSTRAT-1856.
3225+
clientID is the client ID of a managed identity associated with CredentialsSecretName. This field is optional and
3226+
mainly used for CI purposes.
32303227
type: string
32313228
x-kubernetes-validations:
32323229
- message: the client ID of a managed identity
@@ -3284,9 +3281,8 @@ spec:
32843281
type: string
32853282
clientID:
32863283
description: |-
3287-
clientID is the client ID of a managed identity.
3288-
Deprecated: This field was previously required as part of the MIWI phase 2 work; however, this field will be
3289-
removed as part of the MIWI phase 3 work, https://issues.redhat.com/browse/OCPSTRAT-1856.
3284+
clientID is the client ID of a managed identity associated with CredentialsSecretName. This field is optional and
3285+
mainly used for CI purposes.
32903286
type: string
32913287
x-kubernetes-validations:
32923288
- message: the client ID of a managed identity
@@ -3344,9 +3340,8 @@ spec:
33443340
type: string
33453341
clientID:
33463342
description: |-
3347-
clientID is the client ID of a managed identity.
3348-
Deprecated: This field was previously required as part of the MIWI phase 2 work; however, this field will be
3349-
removed as part of the MIWI phase 3 work, https://issues.redhat.com/browse/OCPSTRAT-1856.
3343+
clientID is the client ID of a managed identity associated with CredentialsSecretName. This field is optional and
3344+
mainly used for CI purposes.
33503345
type: string
33513346
x-kubernetes-validations:
33523347
- message: the client ID of a managed identity
@@ -3404,9 +3399,8 @@ spec:
34043399
type: string
34053400
clientID:
34063401
description: |-
3407-
clientID is the client ID of a managed identity.
3408-
Deprecated: This field was previously required as part of the MIWI phase 2 work; however, this field will be
3409-
removed as part of the MIWI phase 3 work, https://issues.redhat.com/browse/OCPSTRAT-1856.
3402+
clientID is the client ID of a managed identity associated with CredentialsSecretName. This field is optional and
3403+
mainly used for CI purposes.
34103404
type: string
34113405
x-kubernetes-validations:
34123406
- message: the client ID of a managed identity
@@ -3486,9 +3480,8 @@ spec:
34863480
type: string
34873481
clientID:
34883482
description: |-
3489-
clientID is the client ID of a managed identity.
3490-
Deprecated: This field was previously required as part of the MIWI phase 2 work; however, this field will be
3491-
removed as part of the MIWI phase 3 work, https://issues.redhat.com/browse/OCPSTRAT-1856.
3483+
clientID is the client ID of a managed identity associated with CredentialsSecretName. This field is optional and
3484+
mainly used for CI purposes.
34923485
type: string
34933486
x-kubernetes-validations:
34943487
- message: the client ID of a managed identity
@@ -3547,9 +3540,8 @@ spec:
35473540
type: string
35483541
clientID:
35493542
description: |-
3550-
clientID is the client ID of a managed identity.
3551-
Deprecated: This field was previously required as part of the MIWI phase 2 work; however, this field will be
3552-
removed as part of the MIWI phase 3 work, https://issues.redhat.com/browse/OCPSTRAT-1856.
3543+
clientID is the client ID of a managed identity associated with CredentialsSecretName. This field is optional and
3544+
mainly used for CI purposes.
35533545
type: string
35543546
x-kubernetes-validations:
35553547
- message: the client ID of a managed identity
@@ -4334,9 +4326,8 @@ spec:
43344326
type: string
43354327
clientID:
43364328
description: |-
4337-
clientID is the client ID of a managed identity.
4338-
Deprecated: This field was previously required as part of the MIWI phase 2 work; however, this field will be
4339-
removed as part of the MIWI phase 3 work, https://issues.redhat.com/browse/OCPSTRAT-1856.
4329+
clientID is the client ID of a managed identity associated with CredentialsSecretName. This field is optional and
4330+
mainly used for CI purposes.
43404331
type: string
43414332
x-kubernetes-validations:
43424333
- message: the client ID of a managed identity must

‎api/hypershift/v1beta1/zz_generated.featuregated-crd-manifests/hostedclusters.hypershift.openshift.io/AutoNodeKarpenter.yaml

+18-27
Original file line numberDiff line numberDiff line change
@@ -3144,9 +3144,8 @@ spec:
31443144
type: string
31453145
clientID:
31463146
description: |-
3147-
clientID is the client ID of a managed identity.
3148-
Deprecated: This field was previously required as part of the MIWI phase 2 work; however, this field will be
3149-
removed as part of the MIWI phase 3 work, https://issues.redhat.com/browse/OCPSTRAT-1856.
3147+
clientID is the client ID of a managed identity associated with CredentialsSecretName. This field is optional and
3148+
mainly used for CI purposes.
31503149
type: string
31513150
x-kubernetes-validations:
31523151
- message: the client ID of a managed identity
@@ -3205,9 +3204,8 @@ spec:
32053204
type: string
32063205
clientID:
32073206
description: |-
3208-
clientID is the client ID of a managed identity.
3209-
Deprecated: This field was previously required as part of the MIWI phase 2 work; however, this field will be
3210-
removed as part of the MIWI phase 3 work, https://issues.redhat.com/browse/OCPSTRAT-1856.
3207+
clientID is the client ID of a managed identity associated with CredentialsSecretName. This field is optional and
3208+
mainly used for CI purposes.
32113209
type: string
32123210
x-kubernetes-validations:
32133211
- message: the client ID of a managed identity
@@ -3265,9 +3263,8 @@ spec:
32653263
type: string
32663264
clientID:
32673265
description: |-
3268-
clientID is the client ID of a managed identity.
3269-
Deprecated: This field was previously required as part of the MIWI phase 2 work; however, this field will be
3270-
removed as part of the MIWI phase 3 work, https://issues.redhat.com/browse/OCPSTRAT-1856.
3266+
clientID is the client ID of a managed identity associated with CredentialsSecretName. This field is optional and
3267+
mainly used for CI purposes.
32713268
type: string
32723269
x-kubernetes-validations:
32733270
- message: the client ID of a managed identity
@@ -3325,9 +3322,8 @@ spec:
33253322
type: string
33263323
clientID:
33273324
description: |-
3328-
clientID is the client ID of a managed identity.
3329-
Deprecated: This field was previously required as part of the MIWI phase 2 work; however, this field will be
3330-
removed as part of the MIWI phase 3 work, https://issues.redhat.com/browse/OCPSTRAT-1856.
3325+
clientID is the client ID of a managed identity associated with CredentialsSecretName. This field is optional and
3326+
mainly used for CI purposes.
33313327
type: string
33323328
x-kubernetes-validations:
33333329
- message: the client ID of a managed identity
@@ -3385,9 +3381,8 @@ spec:
33853381
type: string
33863382
clientID:
33873383
description: |-
3388-
clientID is the client ID of a managed identity.
3389-
Deprecated: This field was previously required as part of the MIWI phase 2 work; however, this field will be
3390-
removed as part of the MIWI phase 3 work, https://issues.redhat.com/browse/OCPSTRAT-1856.
3384+
clientID is the client ID of a managed identity associated with CredentialsSecretName. This field is optional and
3385+
mainly used for CI purposes.
33913386
type: string
33923387
x-kubernetes-validations:
33933388
- message: the client ID of a managed identity
@@ -3445,9 +3440,8 @@ spec:
34453440
type: string
34463441
clientID:
34473442
description: |-
3448-
clientID is the client ID of a managed identity.
3449-
Deprecated: This field was previously required as part of the MIWI phase 2 work; however, this field will be
3450-
removed as part of the MIWI phase 3 work, https://issues.redhat.com/browse/OCPSTRAT-1856.
3443+
clientID is the client ID of a managed identity associated with CredentialsSecretName. This field is optional and
3444+
mainly used for CI purposes.
34513445
type: string
34523446
x-kubernetes-validations:
34533447
- message: the client ID of a managed identity
@@ -3527,9 +3521,8 @@ spec:
35273521
type: string
35283522
clientID:
35293523
description: |-
3530-
clientID is the client ID of a managed identity.
3531-
Deprecated: This field was previously required as part of the MIWI phase 2 work; however, this field will be
3532-
removed as part of the MIWI phase 3 work, https://issues.redhat.com/browse/OCPSTRAT-1856.
3524+
clientID is the client ID of a managed identity associated with CredentialsSecretName. This field is optional and
3525+
mainly used for CI purposes.
35333526
type: string
35343527
x-kubernetes-validations:
35353528
- message: the client ID of a managed identity
@@ -3588,9 +3581,8 @@ spec:
35883581
type: string
35893582
clientID:
35903583
description: |-
3591-
clientID is the client ID of a managed identity.
3592-
Deprecated: This field was previously required as part of the MIWI phase 2 work; however, this field will be
3593-
removed as part of the MIWI phase 3 work, https://issues.redhat.com/browse/OCPSTRAT-1856.
3584+
clientID is the client ID of a managed identity associated with CredentialsSecretName. This field is optional and
3585+
mainly used for CI purposes.
35943586
type: string
35953587
x-kubernetes-validations:
35963588
- message: the client ID of a managed identity
@@ -4367,9 +4359,8 @@ spec:
43674359
type: string
43684360
clientID:
43694361
description: |-
4370-
clientID is the client ID of a managed identity.
4371-
Deprecated: This field was previously required as part of the MIWI phase 2 work; however, this field will be
4372-
removed as part of the MIWI phase 3 work, https://issues.redhat.com/browse/OCPSTRAT-1856.
4362+
clientID is the client ID of a managed identity associated with CredentialsSecretName. This field is optional and
4363+
mainly used for CI purposes.
43734364
type: string
43744365
x-kubernetes-validations:
43754366
- message: the client ID of a managed identity must

0 commit comments

Comments
 (0)