-
Notifications
You must be signed in to change notification settings - Fork 363
CNTRLPLANE-216: Add KubeAPIExteralName api #5458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@jparrill: This pull request references HOSTEDCP-1960 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jparrill The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
90afcc8
to
c866941
Compare
@jparrill: This pull request references HOSTEDCP-1960 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@jparrill: This pull request references HOSTEDCP-1960 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
5152979
to
0ecdf6a
Compare
Can we elaborate on this? Which topologies is this use case targeting: privateAndPublic, private, public? |
0ecdf6a
to
d6e3182
Compare
@jparrill: This pull request references HOSTEDCP-1960 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
d6e3182
to
dfb1320
Compare
f68c435
to
1fd6696
Compare
/lgtm |
1 similar comment
Signed-off-by: Juan Manuel Parrilla Madrid <jparrill@redhat.com>
/lgtm |
/override "Red Hat Konflux / hypershift-operator-main-enterprise-contract / hypershift-operator-main" |
@bryan-cox: Overrode contexts on behalf of bryan-cox: Red Hat Konflux / hypershift-operator-main-enterprise-contract / hypershift-operator-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override "Red Hat Konflux / hypershift-operator-main-on-pull-request" |
@bryan-cox: Overrode contexts on behalf of bryan-cox: Red Hat Konflux / hypershift-operator-main-on-pull-request In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test e2e-aws |
/hold Revision f0b828b was retested 3 times: holding |
/retest |
@jparrill: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/hold cancel |
/test e2e-aws-4-18 |
712c702
into
openshift:main
[ART PR BUILD NOTIFIER] Distgit: hypershift |
This new API autogenerate a new kubeconfig based on a desired url and managed by HCP.
What this PR does / why we need it:
The current implementation of HCP to define the KAS address is using the ServicePublishingType, where you can define a hostname and that, will customize the API and API-INT interfaces where all the kubeconfigs (excepts the ones pointing to local) are pointing to. This makes the customization rigid and customers are asking for more flexibility.
This PR adds a new API which creates a new Kubeconfig (certificate based) pointing to the desired address. With this new API you can:
customKubeconfig
Which issue(s) this PR fixes:
Checklist