Skip to content

proof: Promotes RouteExternalCertificateRef feature gate #6064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

proof: Promotes RouteExternalCertificateRef feature gate #6064

wants to merge 3 commits into from

Conversation

swghosh
Copy link
Member

@swghosh swghosh commented Apr 21, 2025 •
edited
Loading

Bumps o/api to promote RouteExternalCertificateRef feature gate,
proof: vendors from openshift/api#2268.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 21, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 21, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@swghosh @chiragkyal
Fake bump: promotes feature gate RouteExternalCertificateRef
e717dea 
Co-authored-by: Chirag Kyal <ckyal@redhat.com>
Signed-off-by: Swarup Ghosh <swghosh@redhat.com>
@openshift-ci openshift-ci bot added the area/api Indicates the PR includes changes for the API label Apr 21, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 21, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: swghosh
Once this PR has been reviewed and has the lgtm label, please assign enxebre for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@swghosh swghosh force-pushed the promote-fg-route-external-certificate-ref branch from de5eab2 to e717dea Compare April 21, 2025 18:33
@swghosh
Copy link
Member Author

swghosh commented Apr 21, 2025

/test images

@swghosh swghosh changed the title WIP: Promotes RouteExternalCertificateRef feature gate proof: Promotes RouteExternalCertificateRef feature gate Apr 21, 2025
@swghosh swghosh marked this pull request as ready for review April 21, 2025 19:07
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 21, 2025
@openshift-ci openshift-ci bot requested review from enxebre and hasueki April 21, 2025 19:07
@swghosh
Update test fixtures with new FGs
c3d8988 
* `UPDATE=true go test ./...`

Signed-off-by: Swarup Ghosh <swghosh@redhat.com>
@openshift-ci openshift-ci bot added the area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release label Apr 21, 2025
@swghosh
Copy link
Member Author

swghosh commented Apr 21, 2025

/cc @chiragkyal

@openshift-ci openshift-ci bot requested a review from chiragkyal April 21, 2025 19:30
@cwbotbot
Copy link

cwbotbot commented Apr 21, 2025 •
edited
Loading

Test Results

e2e-aks

e2e-aws

@swghosh
Copy link
Member Author

swghosh commented Apr 21, 2025

/testwith openshift/api/master/e2e-aws-ovn-hypershift-conformance openshift/api#2268

@swghosh
Render feature gates into openshift-apiserver params
3c61efc 
Signed-off-by: Swarup Ghosh <swghosh@redhat.com>
@swghosh
Copy link
Member Author

swghosh commented Apr 22, 2025

/testwith openshift/api/master/e2e-aws-ovn-hypershift-conformance openshift/api#2268

@swghosh swghosh mentioned this pull request Apr 22, 2025
Merged
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 22, 2025

@swghosh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 3c61efc link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@swghosh
Copy link
Member Author

swghosh commented Apr 22, 2025

/close

3c61efc was maneuvered in #6068 and e717dea is redundant as of #6060.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 22, 2025
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot closed this Apr 22, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 22, 2025

@swghosh: Closed this PR.

In response to this:

/close

3c61efc was maneuvered in #6068 and e717dea is redundant as of #6060.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enxebre enxebre Awaiting requested review from enxebre

@hasueki hasueki Awaiting requested review from hasueki

@chiragkyal chiragkyal Awaiting requested review from chiragkyal

Assignees
No one assigned
Labels
area/api Indicates the PR includes changes for the API area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swghosh @cwbotbot @openshift-merge-robot