MCO-1615: Mco node degraded mcn condition #29684
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
pablintino
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@pablintino: This pull request references MCO-1615 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-merge-robot
added
the
needs-rebase
pablintino
force-pushed
the
mco-node-degraded-mcn-condition
branch
from
27b2923 to
3bd651f
Compare
openshift-merge-robot
removed
the
needs-rebase
openshift-ci
bot
added
the
approved
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/test e2e-aws-ovn-microshift Running this test to see the stability of it. |
openshift-merge-robot
added
the
needs-rebase
pablintino
force-pushed
the
mco-node-degraded-mcn-condition
branch
from
3bd651f to
52f6ff9
Compare
openshift-merge-robot
removed
the
needs-rebase
|
/retest-required |
|
Job Failure Risk Analysis for sha: 52f6ff9
Showing 20 of 26 jobs analysis |
The MCN API has a condition to signal a failure durint the update of a MachineConfigNode. The condition was already in the API but the MCO was not handling it. With the MCO now handling the condition our testing now needs to check it is properly set/unset when needed.
pablintino
force-pushed
the
mco-node-degraded-mcn-condition
branch
from
52f6ff9 to
16317c0
Compare
|
/retest |
|
/test e2e-aws-ovn-serial |
|
@pablintino: The specified target(s) for The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm This looks good to me, but the test isn't part of a suite. I'm happy to merge as is, and evaluate issues as they arise when we create a suite for this. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: djoshy, pablintino The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM too! Thanks @pablintino |
|
@pablintino: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Job Failure Risk Analysis for sha: 16317c0
|
|
/retest-required |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MCN API has a condition to signal a failure durint the update of a MachineConfigNode. The condition was already in the API but the MCO was not handling it.
With the MCO now handling the condition our testing now needs to check it is properly set/unset when needed.