OCPBUGS-55211: use regular user to create httproute #29697
Conversation
openshift-ci-robot
added
jira/severity-important
|
@lihongan: This pull request references Jira Issue OCPBUGS-55211, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@lihongan: This pull request references Jira Issue OCPBUGS-55211, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: lihongan. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| gateway := &gatewayapiv1.Gateway{} | ||
|
|
||
| waitErr := wait.PollUntilContextTimeout(context.Background(), 2*time.Second, 10*time.Minute, false, func(context context.Context) (bool, error) { | ||
| gateway, errGwStatus := gwapiClient.GatewayV1().Gateways(ingressNameSpace).Get(context, gwname, metav1.GetOptions{}) | ||
| if errGwStatus != nil { | ||
| gateway, err = oc.AdminGatewayApiClient().GatewayV1().Gateways(ingressNameSpace).Get(context, gwname, metav1.GetOptions{}) |
There was a problem hiding this comment.
Should not use := here, otherwise the gateway.Name is empty in logs as below
I0422 15:27:59.859132 34018 gatewayapicontroller.go:352] Gateway "" successfully programmed!
| } | ||
| e2e.Logf("Gateway %q successfully programmed!", gateway.Name) | ||
| return gateway, nil | ||
| } | ||
|
|
||
| // buildGateway initializes the Gateway and returns its address. | ||
| func buildGateway(name, namespace, gcname, fromNs, domain string) *gatewayapiv1.Gateway { | ||
| hostname := gatewayapiv1.Hostname("*." + "gwapi." + domain) | ||
| hostname := gatewayapiv1.Hostname("*." + domain) |
There was a problem hiding this comment.
Needn't to insert gwapi. to the hostname, otherwise it looks like
spec:
gatewayClassName: openshift-default
listeners:
- allowedRoutes:
namespaces:
from: All
hostname: '*.gwapi.gw-default.ci-ln-3if6zbk-72292.origin-ci-int-gce.dev.rhcloud.com'
Indeed, we replace apps. to gw-xxx. in the test to generate the domain for gateway.
|
/test e2e-gcp-ovn-techpreview |
|
/test e2e-gcp-ovn-techpreview |
|
/payload-job periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-techpreview periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-dualstack-techpreview periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-ipv6-techpreview periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview periodic-ci-openshift-multiarch-master-nightly-4.19-ocp-e2e-aws-ovn-techpreview-multi-a-a periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ipi-ovn-runc-techpreview |
|
@lihongan: trigger 6 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3987ae80-1ff4-11f0-87b0-4cf6a73fa7bb-0 |
lihongan
changed the title
|
|
||
| g.By("Create the http route using the custom gateway") | ||
| httproutes = append(httproutes, "test-httproute") | ||
| defaultRoutename := "test-hostname.gwapi." + customDomain | ||
| defaultRoutename := "test-hostname." + customDomain |
There was a problem hiding this comment.
Removing the gwapi. to match the change in func buildGateway()
There was a problem hiding this comment.
LGTM overall, just a couple of nit picks. Do you plan to hold the merge of this PR until openshift/api#2284 is merged?
|
/test e2e-gcp-ovn-techpreview |
|
/payload-job periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-techpreview periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-dualstack-techpreview periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-ipv6-techpreview periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ipi-ovn-runc-techpreview periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-techpreview |
|
@lihongan: trigger 6 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b2f84f70-20e6-11f0-85b1-f4e8960d0d92-0 |
|
Job Failure Risk Analysis for sha: 7c59634
|
|
/test e2e-gcp-ovn-techpreview |
|
/payload-job periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-techpreview periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-dualstack-techpreview periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-ipv6-techpreview periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ipi-ovn-runc-techpreview periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-techpreview |
|
@lihongan: trigger 6 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ea8a8580-2112-11f0-95a4-05dc2bf9eef1-0 |
|
Job Failure Risk Analysis for sha: a38486b
|
1. use regular user to create httproute as well as pod/service 2. remove the step of cleaning up httproute
|
New changes are detected. LGTM label has been removed. |
openshift-merge-robot
removed
the
needs-rebase
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: alebedev87, lihongan The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Resolved the conflicts and force pushed again, retesting... |
|
/jira refresh |
openshift-ci-robot
added
jira/invalid-bug
|
@lihongan: This pull request references Jira Issue OCPBUGS-55211, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@lihongan: This pull request references Jira Issue OCPBUGS-55211, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (iamin@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Job Failure Risk Analysis for sha: aaa81c0
|
|
Job Failure Risk Analysis for sha: aaa81c0
|
|
/assign @Miciah |
|
/retest-required |
|
Job Failure Risk Analysis for sha: aaa81c0
|
|
/retest-required |
|
@lihongan: An error was encountered searching for bug OCPBUGS-55211 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details. Full error message.
No response returned: Get "https://issues.redhat.com/rest/api/2/issue/OCPBUGS-55211": GET https://issues.redhat.com/rest/api/2/issue/OCPBUGS-55211 giving up after 5 attempt(s)
Please contact an administrator to resolve this issue, then request a bug refresh with In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@lihongan: This pull request references Jira Issue OCPBUGS-55211, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (iamin@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@lihongan: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Job Failure Risk Analysis for sha: aaa81c0
|
|
Job Failure Risk Analysis for sha: aaa81c0
|
enhancement for httproute test