Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNM: OADP-5404: CVE-2024-45338, update x/net and x/crypto #357

Open
wants to merge 1 commit into
base: oadp-1.4
Choose a base branch
from

Conversation

weshayutin
Copy link

@weshayutin weshayutin commented Jan 15, 2025

Thank you for contributing to Velero!

Please add a summary of your change

Updating x/net to 1.33 because velero main branch is using 1.33
https://github.com/vmware-tanzu/velero/blob/main/go.mod#L46

There are several CVE issues on x/net and x/crypto

Does your change fix a particular issue?

Fixes #OADP-5404

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 15, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 15, 2025

@weshayutin: This pull request references OADP-5404 which is a valid jira issue.

In response to this:

Thank you for contributing to Velero!

Please add a summary of your change

Updating x/net to 1.33 because velero main branch is using 1.33
https://github.com/vmware-tanzu/velero/blob/main/go.mod#L46

There are several CVE issues on x/net and x/crypto

Does your change fix a particular issue?

Fixes #OADP-5404

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@weshayutin weshayutin self-assigned this Jan 15, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 15, 2025

@weshayutin: This pull request references OADP-5404 which is a valid jira issue.

In response to this:

Thank you for contributing to Velero!

Please add a summary of your change

Updating x/net to 1.33 because velero main branch is using 1.33
https://github.com/vmware-tanzu/velero/blob/main/go.mod#L46

There are several CVE issues on x/net and x/crypto

Does your change fix a particular issue?

Fixes #OADP-5404

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@weshayutin weshayutin added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Jan 15, 2025
@weshayutin
Copy link
Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 15, 2025
Copy link

openshift-ci bot commented Jan 15, 2025

@weshayutin: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

openshift-ci bot commented Jan 16, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kaovilai, sseago, weshayutin

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants