Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

Commit

Permalink
Merge pull request #169 from PratikMahajan/contribution-guidelines-up…
Browse files Browse the repository at this point in the history
…date

[docs] Update Contribution Guidelines
  • Loading branch information
openshift-merge-robot authored Mar 25, 2020
2 parents de77551 + 16de131 commit 0d63538
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion CONTRIBUTION.md
Original file line number Diff line number Diff line change
Expand Up @@ -74,11 +74,13 @@ git tools.
- Ensure each PR commit compiles and all unit and e2e tests pass on your local machine.
- PRs that have vendor commits are an exception to this rule.
- Following are the things you should keep in mind once you open a PR:
- Add a hold as soon as you open the PR by commenting `/hold`
- Wait for comments from at least 2 reviewers before pushing changes.
Open comments in the meanwhile can be worked on locally.
- PR comments should be addressed in new commits. Before final approval, they have to be squashed.
- If PR has multiple commits, changes requested should eventually be squashed into the original commit where the
change was requested before the final merge. Each commit in the final PR before merge should pass the tests and be
change was requested before cancelling the hold. Each commit in the final PR before merge should pass the tests and be
usable. (see below)
- Once the PR is approved, remove the hold by commenting `/hold cancel` to merge the PR

![Sample PR life-cycle](/images/PR-workflow.png)

0 comments on commit 0d63538

Please sign in to comment.