-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added/Updated Superchain DEX projects #643
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The entry looks great! We haven't tested anything through Soneium yet.
Is there are a public GitHub URL that we can associate with the project? That would be the only thing missing typically.
Yes. Just added the Github link. Thanks for checking this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Promote the Github artifact to a first level element
data/projects/k/kyo-finance.yaml
Outdated
social: | ||
twitter: | ||
- url: https://twitter.com/kyofinance | ||
github: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a first level entry, at the same level as websites, social, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
@kaiblade do you want to convert this from draft mode now so I can review / merge it? |
@ccerv1 Hello, kindly review this PR. |
/validate 23201ce |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! great work
/validate 23201ce |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are several issues that need to be addressed:
1.name
fields take strings, not arrays
For example, this will be rejected
name:
- FarmingVault_cbBTC
Should be name: FarmingVault_cbBTC
-
celo
is not a supported network. Please remove this from all networks. Any contracts only on Celo should also be removed. -
token
is not a supported address tag
I believe these are the main issues.
Please try developing locally and running pnpm validate
to check for schema correctness.
I was unable to make commits to your branch, so I pushed them to this PR. I think I reviewed about half of the projects. |
/validate 9f2ecac |
No description provided.