Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Sync status handling to migrate to CurrentSyncJobStatus #3059

Closed
ndegwamartin opened this issue Feb 12, 2024 · 4 comments · Fixed by #3136
Closed

Refactor Sync status handling to migrate to CurrentSyncJobStatus #3059

ndegwamartin opened this issue Feb 12, 2024 · 4 comments · Fixed by #3136

Comments

@ndegwamartin
Copy link
Contributor

Describe the feature request.
We need to migrate from using SyncJobStatus to using CurrentSyncJobStatus which has both work state and SyncJobStatus state representations.

Additional context
This follows the upgrade SDK libraries PR #2825 changes

Acceptance criteria
A check list of all things to verify once the implementation by the engineer is complete

Area path
A list of ordered steps in the app on usage of the feature to support anyone testing it e.g. Code reviewer, QA e.g.

  1. Login to the app
  2. Open Navigation bar
  3. Click on Children register
  4. Click on Child profile
  5. Click on Edit profile from menu

Implementation plan (For Engineers)
The plan for implementing the solution e.g. via a description or a check list for the various ordered tasks that will need to be completed.
i.e. Describe how you intend to solve the problem

@pld
Copy link
Member

pld commented Feb 12, 2024

Is this cleanup only or do we get a functional benefit from this change?

@ndegwamartin
Copy link
Contributor Author

Is this cleanup only or do we get a functional benefit from this change?

This is related to the findings here #2942

@ellykits
Copy link
Collaborator

This should be code cleanup plus it will improve the sync notification UX.

@ndegwamartin
Copy link
Contributor Author

Note: The issue #2942 is still blocked by google/android-fhir#2472

@pld pld closed this as completed in #3136 Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants