Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add targetSdk to modules #3407

Closed
FikriMilano opened this issue Jul 26, 2024 · 4 comments · Fixed by #3369
Closed

Add targetSdk to modules #3407

FikriMilano opened this issue Jul 26, 2024 · 4 comments · Fixed by #3369
Assignees
Labels
Good First Issue Good for newcomers

Comments

@FikriMilano
Copy link
Collaborator

FikriMilano commented Jul 26, 2024

Describe the Issue
We have defined API 34 as our latest targetSdk, but it has not been applied to our modules. Add the targetSdk to prevent this prompt to appear when installing the app.

Screen Shot 2024-07-26 at 10 26 31

Original issue: https://github.com/ona-health/sid-dto-fhir-resources/issues/909

@FikriMilano FikriMilano added the Good First Issue Good for newcomers label Jul 26, 2024
@FikriMilano
Copy link
Collaborator Author

@f-odhiambo @ndegwamartin

@ndegwamartin
Copy link
Contributor

@FikriMilano which version of the code base are you building from?

@FikriMilano
Copy link
Collaborator Author

I checked the main branch.
No this doesn't happen to me, it was the issue you reported that happens in SID

@ndegwamartin
Copy link
Contributor

Following the merge of this PR this has since been fixed - #3369

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants