CI Workflow Dependency Upgrades + Optimization 👷 #3369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3369 +/- ##
=========================================
- Coverage 28.2% 28.1% -0.1%
Complexity 718 718
=========================================
Files 265 265
Lines 12871 12881 +10
Branches 2313 2315 +2
=========================================
Hits 3630 3630
- Misses 8765 8774 +9
- Partials 476 477 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
ndegwamartin
force-pushed
the
ci-opti-upgrade
branch
3 times, most recently
from
fc4baea to
5b5d1c2
Compare
pld
previously approved these changes
Jul 9, 2024
ndegwamartin
force-pushed
the
ci-opti-upgrade
branch
from
5b5d1c2 to
00c18ba
Compare
|
this is the main error I see in the quest logs |
ndegwamartin
force-pushed
the
ci-opti-upgrade
branch
from
1756322 to
13d559c
Compare
ellykits
reviewed
Jul 18, 2024
| @@ -17,7 +18,7 @@ env: | |||
|
|
|||
| jobs: | |||
| engine-tests: | |||
| runs-on: macos-13 | |||
| runs-on: ubuntu-latest | |||
There was a problem hiding this comment.
Does the Ubuntu image include an emulator? The macOS image was used to allow us to run instrumentation tests.
There was a problem hiding this comment.
The performance tests require an emulator to run.
There was a problem hiding this comment.
There was a problem hiding this comment.
Yeah and its actually much faster. Preliminary tests show around 50% improvement for the jobs
This is caused by disabling the instrumentation tests in the gradle configuration file. When disabled the reporting artifacts are not loaded. Note, we can only enable it after resolving #3055 |
- Add workflow dispatch event trigger - Disable CI runs for working modules - Reset Quest test run and reporting configuration
- Update path to emulator SDK - Enable Engine and Geowidget jobs
ndegwamartin
force-pushed
the
ci-opti-upgrade
branch
from
7fa9fe1 to
1d0685e
Compare
* Upgrade JUnit 5 * Update CI configuration for maintainability 👷 * Refactor Gradle Configs for maintainability 🔧 * Refactor unit tests to runTest
pld
approved these changes
Jul 24, 2024
qiarie
pushed a commit
that referenced
this pull request
Jan 15, 2025
* CI Workflow Dependency Upgrades + Optimization 👷 * Migrate CI workflow to use Ubuntu runner * Update CI Workflow with KVM * Troubleshooting: Force recreation of AVD for Quest * Troubleshooting: Update CI Workflow configuration * Update Quest module workflow configuration | AVD * Troubleshooting configuration - Add workflow dispatch event trigger - Disable CI runs for working modules - Reset Quest test run and reporting configuration * Update CI workflow configuration - Update path to emulator SDK - Enable Engine and Geowidget jobs * Update CI workflow configuration:Quest Tests 👷 * Add Target SDK build.gradle configuration 🔧 * Unit Test troubleshooting * Unit Test troubleshooting * Troubleshooting: Quest module Unit Tests * Apply Spotless to Quest * [DNM] Quest Module tests troubleshooting (#3387) * Upgrade JUnit 5 * Update CI configuration for maintainability 👷 * Refactor Gradle Configs for maintainability 🔧 * Refactor unit tests to runTest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Where possible all PRs must be linked to a Github issue
Resolves #3407
Engineer Checklist
strings.xmlfile./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the project's style guideCode Reviewer Checklist
strings.xmlfile