fix: checkbox filter disappearing fix #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: checkbox filter disappearing fix
|
@alexhey1999 is attempting to deploy a commit to the OpenStatus Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mxkaske
reviewed
May 28, 2025
There was a problem hiding this comment.
Hey @alexhey1999! Sorry for the late response. Good catch on that one. Left a small comment.
| @@ -73,7 +71,7 @@ export function DataTableFilterCheckbox<TData>({ | |||
| ) : null} | |||
| {/* FIXME: due to the added max-h and overflow-y-auto, the hover state and border is laying on top of the scroll bar */} | |||
| <div className="max-h-[200px] overflow-y-auto rounded-lg border border-border empty:border-none"> | |||
| {filterOptions | |||
| {filterOptions! | |||
There was a problem hiding this comment.
Instead of forcing it with !, can we use optional chaining (?) instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a potential resolution to the issue of the checkbox component disappearing entirely when the user filters down to the point where no results are returned. I'm not sure if this will have any knock-on effects across the repo.
How to replicate:
Fix:
Will no longer return null for the whole component. This way, the options disappear as intended, allowing the user to alter the text input to see more results.
Issue
issue.mp4
Fixed Version
fix.mp4