drop "Portable Toilets" preset #1159
Conversation
|
🍱 You can preview the tagging presets of this pull request here. |
There was a problem hiding this comment.
This looks good to me. I have the open question (last paragraph) if we should remove the portable field…
In #1148 (comment) the language and changes where approved.
rename generic amenity=toilets preset to "Toilets" (was: "Restroom"), as restroom is typically only used for rooms in a building, but the tag can also be used for outdoor toilets
When a toilet is mapped separately inside the building shape, it also get this updated name, now. Which is something we have to live with, since we cannot target the surrounding shape. I think this is fine. Example https://pr-1159--ideditor-presets-preview.netlify.app/id/dist/#background=Bing&disable_features=boundaries&id=n5938578259&locale=en&map=20.00/47.84838/12.07912
- Overpass https://overpass-turbo.eu/s/1MvD
- Overpass https://overpass-turbo.eu/s/1MvE
Example "portable" https://pr-1159--ideditor-presets-preview.netlify.app/id/dist/#background=Bing&disable_features=boundaries&id=n9124438348&locale=en&map=20.00/48.11587/12.34760
- Overpass https://overpass-turbo.eu/s/1MvF
- Why do we still have the field
. It did sound like we should rather remove it? Maybe even add a deprecation to it?
* rename generic amenity=toilets preset to "Toilets" (was: "Restroom"), as restroom is typically only used for indoor toilets, but the tag can also be used for outdoor ones * rename field for "toilets" tag to "Restroom" (for the opposite reason as above) * move alias "Water Closet" to "Flush Toilets" preset fixes #1148
Fixes #1148 and in addition changes the following strings: