Skip to content

Fix broken pull request template links (#2867) #2883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: staging
Choose a base branch
from
Open

Fix broken pull request template links (#2867) #2883

wants to merge 5 commits into from
+3 −3

Conversation

AgSpades
Copy link

This PR updates the pull request template links to use full paths. This change attempts to address the issue outlined in #2867, where links do not render correctly.

Changes:

  • Replaced links with full paths to .md files
  • Ensured compatibility with GitHub’s preview/render behavior

Related Issue:
Closes #2867

AgSpades added 2 commits May 18, 2025 09:44
@AgSpades
fix: update pull request template links to properly reload appropriat…
7cb256f 
…e template from subdirectory
@AgSpades
fix: update PR template links to use full paths
7310523 
Updated pull request template links to point to the correct `.github/PULL_REQUEST_TEMPLATE/*.md` files for proper rendering and navigation.
@AgSpades AgSpades marked this pull request as ready for review May 18, 2025 04:56
@thewhaleking thewhaleking requested a review from a team May 18, 2025 07:27
@basfroman basfroman changed the base branch from master to staging May 18, 2025 07:27
thewhaleking
thewhaleking requested changes May 18, 2025
View reviewed changes
Copy link
Contributor

@thewhaleking thewhaleking left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of these links work.

@AgSpades
fix: template rendering with required 'expand' query parameter
0e463b8 
The issue wasn't with the path itself, but with GitHub requiring the
additional 'expand=1' query parameter for proper template rendering.
This change ensures the correct behavior when selecting pull request
templates.
@AgSpades
Copy link
Author

Sorry for the trouble. This should work now. Please check and let me know.

@AgSpades AgSpades requested a review from thewhaleking May 20, 2025 09:01
@thewhaleking
Copy link
Contributor

Sorry for the trouble. This should work now. Please check and let me know.

None of these links work, still.

@basfroman basfroman requested a review from a team May 20, 2025 17:39
@AgSpades
Copy link
Author

Sorry for the trouble. This should work now. Please check and let me know.

None of these links work, still.

Could you please tell me how you checked the functionalities of my changes?

I mean in order to check whether the PR templates are loading properly or not, you need to try opening a PR to the branch(where I have made changes to the templates file).

Before going to the preview section, please see if the additional query parameter expand is present in each of the links.

@basfroman
Copy link
Contributor

Sorry for the trouble. This should work now. Please check and let me know.

None of these links work, still.

Could you please tell me how you checked the functionalities of my changes?

I mean in order to check whether the PR templates are loading properly or not, you need to try opening a PR to the branch(where I have made changes to the templates file).

Before going to the preview section, please see if the additional query parameter expand is present in each of the links.

this works for me

pip install linkcheckmd
python -m linkcheckmd .github/pull_request_template.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basfroman basfroman basfroman approved these changes

@thewhaleking thewhaleking Awaiting requested review from thewhaleking

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Links broken on pull request template
3 participants
@AgSpades @thewhaleking @basfroman