Merge pull request #109 from opentensor/fix/roman/wallet.create_from_uri

Fix `wallet.create_coldkey_from_uri broken`

Author: sam0x17

src/python_bindings.rs

@@ -1101,7 +1101,7 @@ except argparse.ArgumentError:
     }
 
     #[pyo3(
-        signature = (uri, use_password=None, overwrite=None, suppress=None, save_coldkey_to_env=None, coldkey_password=None)
+        signature = (uri, use_password=false, overwrite=false, suppress=true, save_coldkey_to_env=false, coldkey_password=None)
     )]
     fn create_coldkey_from_uri(
         &mut self,
@@ -1131,7 +1131,7 @@ except argparse.ArgumentError:
     }
 
     #[pyo3(
-        signature = (uri, use_password=None, overwrite=None, suppress=None, save_hotkey_to_env=None, hotkey_password=None)
+        signature = (uri, use_password=false, overwrite=false, suppress=true, save_hotkey_to_env=false, hotkey_password=None)
     )]
     fn create_hotkey_from_uri(
         &mut self,

src/wallet.rs

@@ -463,8 +463,6 @@ impl Wallet {
         if !suppress {
             if let Some(m) = keypair.mnemonic() {
                 display_mnemonic_msg(m, "coldkey");
-            } else {
-                return Err(KeyFileError::Generic("Failed to get mnemonic".to_string()));
             }
         }
 
@@ -495,8 +493,6 @@ impl Wallet {
         if !suppress {
             if let Some(m) = keypair.mnemonic() {
                 display_mnemonic_msg(m, "hotkey");
-            } else {
-                return Err(KeyFileError::Generic("Failed to get mnemonic".to_string()));
             }
         }
 

tests/test_wallet.py

@@ -195,3 +195,35 @@ def test_wallet_string_representation_with_custom_arguments():
     assert w.name == wallet_name
     assert w.hotkey_str == wallet_hotkey
     assert w.path == wallet_path
+
+
+def test_create_coldkey_from_uri():
+    """Tests create_coldkey_from_uri method."""
+    # Preps
+    wallet_name = "test_wallet"
+    wallet_hotkey = "test_hotkey"
+    wallet_path = "/tmp/tests_wallets/"
+
+    # Call
+    w = Wallet(name=wallet_name, hotkey=wallet_hotkey, path=wallet_path)
+    w.create_coldkey_from_uri("//test", use_password=False, overwrite=True)
+
+    # Asserts
+    assert w.coldkey.ss58_address is not None
+    assert w.coldkeypub.ss58_address is not None
+
+
+def test_hotkey_coldkey_from_uri():
+    """Tests create_coldkey_from_uri method."""
+    # Preps
+    wallet_name = "test_wallet"
+    wallet_hotkey = "test_hotkey"
+    wallet_path = "/tmp/tests_wallets/"
+
+    # Call
+    w = Wallet(name=wallet_name, hotkey=wallet_hotkey, path=wallet_path)
+    w.create_hotkey_from_uri("//test", use_password=False, overwrite=True)
+
+    # Asserts
+    assert w.coldkey.ss58_address is not None
+    assert w.coldkeypub.ss58_address is not None