Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes, improvement, refactoring #124

Merged
merged 6 commits into from
Apr 3, 2025

Conversation

basfroman
Copy link
Contributor

@basfroman basfroman commented Apr 3, 2025

  • added interpreters into workflow (tested with pypi deploy)
  • up-to-date Changelog
  • updated __verion__ logic
  • Cargo.toml cleanup
  • pyi refactoring (mypy doesn't complain anymore)

mypy stopped complaining about (in sdk and btcli):

  • that classes from bittensor_wallet are not a type, but a variable
  • keypair.cc58_address has the incorrect annotation type (fixed)

AI and IDE understand not only the structure, but also arguments and annotations.
IDE makes hints at all levels (module, class, method, function)

Hints tested in poor python, IDE, ipython, Jupyter.

Tested with SKD ans BTCLI

Hints:
image
image

@basfroman basfroman self-assigned this Apr 3, 2025
@basfroman basfroman added bug Something isn't working enhancement New feature or request testing skip-check-rust labels Apr 3, 2025
@basfroman basfroman changed the base branch from main to staging April 3, 2025 07:13
@basfroman basfroman added run-bittensor-sdk-tests Runs Bittensor SDK tests. run-bittensor-cli-tests Runs BTCLI tests. labels Apr 3, 2025
@basfroman basfroman requested a review from a team April 3, 2025 07:37
@basfroman basfroman merged commit b85677e into staging Apr 3, 2025
111 of 121 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request run-bittensor-cli-tests Runs BTCLI tests. run-bittensor-sdk-tests Runs Bittensor SDK tests. skip-check-rust testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants