commit Cargo.lock

Author: open-junius

pallets/subtensor/src/benchmarks.rs

@@ -684,7 +684,7 @@ benchmark_start_call {
   assert_eq!(FirstEmissionBlockNumber::<T>::get(netuid), None);
   let current_block: u64 = Subtensor::<T>::get_current_block_as_u64();
   let duration = <T as Config>::DurationOfStartCall::get();
-  let block: BlockNumberFor<T> = (current_block + duration).try_into().ok().expect("");
+  let block: BlockNumberFor<T> = (current_block + duration).try_into().ok().expect("can't convert to block number");
   frame_system::Pallet::<T>::set_block_number(block);
 
 }: start_call(RawOrigin::Signed(coldkey), netuid)

pallets/subtensor/src/coinbase/run_coinbase.rs

@@ -37,7 +37,7 @@ impl<T: Config> Pallet<T> {
         let current_block: u64 = Self::get_current_block_as_u64();
         log::debug!("Current block: {:?}", current_block);
 
-        // --- 1. Get all netuids (filter out root and new subnet)
+        // --- 1. Get all netuids (filter out root and new subnet without first emission block)
         let subnets: Vec<u16> = Self::get_all_subnet_netuids()
             .into_iter()
             .filter(|netuid| *netuid != 0)

pallets/subtensor/src/lib.rs

@@ -1125,7 +1125,7 @@ pub mod pallet {
     /// ============================
     /// ==== Subnet Parameters =====
     /// ============================
-    /// --- MAP ( netuid ) --> block number of last emission
+    /// --- MAP ( netuid ) --> block number of first emission
     #[pallet::storage]
     pub type FirstEmissionBlockNumber<T: Config> = StorageMap<_, Identity, u16, u64, OptionQuery>;
     /// --- MAP ( netuid ) --> subnet mechanism

pallets/subtensor/src/macros/config.rs

@@ -210,7 +210,7 @@ mod config {
         /// Initial EMA price halving period
         #[pallet::constant]
         type InitialEmaPriceHalvingPeriod: Get<u64>;
-        /// Block number for a new subnet accept the start call extrinsic.
+        /// Block number after a new subnet accept the start call extrinsic.
         #[pallet::constant]
         type DurationOfStartCall: Get<u64>;
     }

pallets/subtensor/src/macros/dispatches.rs

@@ -1917,7 +1917,7 @@ mod dispatches {
         /// * `netuid` - The unique identifier of the subnet on which the call is being initiated.
         ///
         /// # Events
-        /// Emits a `CallInitiated` event on success.
+        /// Emits a `FirstEmissionBlockNumberSet` event on success.
         #[pallet::call_index(92)]
         #[pallet::weight((
             Weight::from_parts(3_000_000, 0).saturating_add(T::DbWeight::get().reads_writes(6, 1)),

pallets/subtensor/src/macros/hooks.rs

@@ -83,7 +83,7 @@ mod hooks {
                 // Remove unused maps entries
 				.saturating_add(migrations::migrate_remove_unused_maps_and_values::migrate_remove_unused_maps_and_values::<T>())
                 // Set last emission block number for all existed subnets before start call feature applied
-                .saturating_add(migrations::migrate_set_last_emission_block_number::migrate_set_last_emission_block_number::<T>());
+                .saturating_add(migrations::migrate_set_first_emission_block_number::migrate_set_first_emission_block_number::<T>());
             weight
         }
 

pallets/subtensor/src/migrations/migrate_set_last_emission_block_number.rs

@@ -11,7 +11,7 @@ pub mod migrate_populate_owned_hotkeys;
 pub mod migrate_rao;
 pub mod migrate_remove_stake_map;
 pub mod migrate_remove_unused_maps_and_values;
-pub mod migrate_set_last_emission_block_number;
+pub mod migrate_set_first_emission_block_number;
 pub mod migrate_set_min_burn;
 pub mod migrate_set_min_difficulty;
 pub mod migrate_stake_threshold;

pallets/subtensor/src/migrations/mod.rs

@@ -419,15 +419,15 @@ fn test_migrate_subnet_volume() {
 }
 
 #[test]
-fn test_migrate_set_last_emission_block_number() {
+fn test_migrate_set_first_emission_block_number() {
     new_test_ext(1).execute_with(|| {
     let netuids: [u16; 3] = [1, 2, 3];
     let block_number = 100;
     for netuid in netuids.iter() {
         add_network(*netuid, 1, 0);
     }
     run_to_block(block_number);
-    let weight = crate::migrations::migrate_set_last_emission_block_number::migrate_set_last_emission_block_number::<Test>();
+    let weight = crate::migrations::migrate_set_first_emission_block_number::migrate_set_first_emission_block_number::<Test>();
 
     let expected_weight: Weight = <Test as Config>::DbWeight::get().reads(3) + <Test as Config>::DbWeight::get().writes(netuids.len() as u64);
     assert_eq!(weight, expected_weight);

pallets/subtensor/src/tests/migration.rs

@@ -664,7 +664,7 @@ pub fn add_network(netuid: u16, tempo: u16, _modality: u16) {
     SubtensorModule::init_new_network(netuid, tempo);
     SubtensorModule::set_network_registration_allowed(netuid, true);
     SubtensorModule::set_network_pow_registration_allowed(netuid, true);
-    FirstEmissionBlockNumber::<Test>::insert(netuid, 0);
+    FirstEmissionBlockNumber::<Test>::insert(netuid, 1);
 }
 
 #[allow(dead_code)]