Skip to content

Commit c097ff8

Browse files
authored
Merge pull request #551 from opentensor/sam-add-companion-labels-check
add CI check for companion labels, update deployment docs
2 parents e8eae82 + 509af18 commit c097ff8

File tree

3 files changed

+39
-3
lines changed

3 files changed

+39
-3
lines changed
+17
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
name: devnet-companion Label Check
2+
on:
3+
pull_request:
4+
types: [opened, labeled, unlabeled, synchronize]
5+
branches: [devnet-ready]
6+
jobs:
7+
check-labels:
8+
runs-on: ubuntu-latest
9+
permissions:
10+
issues: write
11+
pull-requests: write
12+
steps:
13+
- uses: mheap/github-action-required-labels@v5
14+
with:
15+
mode: minimum
16+
count: 1
17+
labels: devnet-companion
+17
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
name: testnet-companion Label Check
2+
on:
3+
pull_request:
4+
types: [opened, labeled, unlabeled, synchronize]
5+
branches: [testnet-ready]
6+
jobs:
7+
check-labels:
8+
runs-on: ubuntu-latest
9+
permissions:
10+
issues: write
11+
pull-requests: write
12+
steps:
13+
- uses: mheap/github-action-required-labels@v5
14+
with:
15+
mode: minimum
16+
count: 1
17+
labels: testnet-companion

CONTRIBUTING.md

+5-3
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@
1515
add appropriate labels to your PR as shown below. Three positive reviews are required.
1616
4. Once the required passing reviews have been obtained, you are ready to request that your PR
1717
be included in the next `devnet` deploy. To do this, you should open a companion PR merging
18-
your branch into the `devnet-ready` branch. You must include a link to the parent PR in the
19-
description and preface your PR title with "(Devnet Ready)" or the PR will be
20-
closed/ignored.
18+
a copy of your branch into the `devnet-ready` branch. You must include a link to the parent
19+
PR in the description and preface your PR title with "(Devnet Ready)" or the PR will be
20+
closed/ignored. Your companion PR should have the `devnet-companion` label.
2121
5. A core team administrator will review your "(Devnet Ready)" PR, verifying that it logically
2222
matches the changes introduced in the parent PR (there will sometimes be minor differences
2323
due to merge conflicts) and will either request changes or approve the PR and merge it. Once
@@ -86,11 +86,13 @@
8686
| `runtime` | PR contains substantive changes to runtime / pallet code | none |
8787
| `breaking-change` | PR requires synchronized changes with bittensor | Triggers an automatic bot message so the relevant teams are made aware of the change well in advance |
8888
| `migration` | PR contains one or more migrations | none |
89+
| `devnet-companion` | Designates a devnet companion PR | Presence of `devnet-companion` label is checked |
8990
| `devnet-ready` | PR's branch has been merged into the `devnet-ready` branch and will be included in the next `devnet` deploy | none |
9091
| `on-devnet` | PR has been deployed to `devnet` | Removes `devnet-ready` |
9192
| `devnet-pass` | PR has passed manual testing on `devnet` | `devnet-pass` or `devnet-skip` required |
9293
| `devnet-skip` | Allows a critical hotfix PR to skip required testing on `devnet` | `devnet-pass` or `devnet-skip` required |
9394
| `devnet-fail` | PR has failed manual testing on `devnet` and requires modification | none |
95+
| `testnet-companion` | Designates a testnet companion PR | Presence of `testnet-companion` label is checked |
9496
| `on-testnet` | PR has been deployed to `testnet` | none |
9597
| `testnet-pass` | PR has passed manual testing on `testnet` | `testnet-pass` or `testnet-skip` required |
9698
| `testnet-skip` | Allows a critical hotfix PR to skip required manual testing and SOP on `testnet` | `testnet-pass` or `testnet-skip` required |

0 commit comments

Comments
 (0)