Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove in/out peers count from subtensor.sh run script #1112

Merged
merged 3 commits into from
Feb 21, 2025

Conversation

ales-otf
Copy link
Contributor

@ales-otf ales-otf commented Dec 23, 2024

Description

This is a request from @prop_physics:

can we update https://github.com/opentensor/subtensor/blob/main/scripts/run/subtensor.sh#L47 to remove the --in-peers 500 --out-peers 500 args? they are causing node crashes now that everyone has been updating their docker images. likely something in the polkadot sdk upgrades over the past year has made them more sensitive to high peer counts. the default values (40 40) work just fine, so we can just remove these args from the startup parameters to fix it

Related Issue(s)

  • Closes #[issue number]

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

@ales-otf ales-otf changed the base branch from main to devnet-ready December 23, 2024 12:53
@github-actions github-actions bot added the hotfix This PR needs to be merged very quickly and will likely skip testing on devnet and testnet label Dec 23, 2024
@opentensor opentensor deleted a comment from github-actions bot Dec 23, 2024
@ales-otf ales-otf added no-spec-version-bump PR does not contain changes that requires bumping the spec version skip-cargo-audit This PR fails cargo audit but needs to be merged anyway and removed hotfix This PR needs to be merged very quickly and will likely skip testing on devnet and testnet labels Dec 23, 2024
@ales-otf ales-otf marked this pull request as ready for review December 23, 2024 12:54
@ales-otf ales-otf requested a review from unconst as a code owner December 23, 2024 12:54
orriin
orriin previously approved these changes Jan 1, 2025
@prop-opentensor
Copy link

prop-opentensor commented Feb 12, 2025

--in-peers and --out-peers should be removed from here as well:
https://github.com/opentensor/subtensor/blob/main/docker-compose.yml
lines 42, 62, 80 and 100

@sam0x17 sam0x17 dismissed orriin’s stale review February 13, 2025 22:16

The merge-base changed after approval.

sam0x17
sam0x17 previously approved these changes Feb 17, 2025
@ales-otf ales-otf dismissed sam0x17’s stale review February 17, 2025 17:12

The merge-base changed after approval.

sam0x17
sam0x17 previously approved these changes Feb 21, 2025
@ales-otf ales-otf dismissed sam0x17’s stale review February 21, 2025 06:43

The merge-base changed after approval.

@sam0x17 sam0x17 merged commit 5793327 into devnet-ready Feb 21, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-spec-version-bump PR does not contain changes that requires bumping the spec version skip-cargo-audit This PR fails cargo audit but needs to be merged anyway
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants