Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and refactor coinbase #1447

Merged
merged 27 commits into from
Mar 25, 2025
Merged

Fix and refactor coinbase #1447

merged 27 commits into from
Mar 25, 2025

Conversation

camfairchild
Copy link
Contributor

@camfairchild camfairchild commented Mar 21, 2025

Description

Related Issue(s)

  • Closes #[issue number]

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

@github-actions github-actions bot added hotfix This PR needs to be merged very quickly and will likely skip testing on devnet and testnet run-bittensor-sdk-tests labels Mar 21, 2025
@camfairchild camfairchild added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Mar 21, 2025
@camfairchild camfairchild changed the title add a pending alpha (to valis) for prop em Fix and refactor coinbase Mar 22, 2025
@camfairchild camfairchild force-pushed the fix/alpha-underpayment branch from f23c0e2 to 99f43db Compare March 25, 2025 17:38
@camfairchild camfairchild changed the base branch from main to devnet-ready March 25, 2025 17:38
@camfairchild camfairchild removed the hotfix This PR needs to be merged very quickly and will likely skip testing on devnet and testnet label Mar 25, 2025
@opentensor opentensor deleted a comment from github-actions bot Mar 25, 2025
sam0x17
sam0x17 previously approved these changes Mar 25, 2025
@sam0x17 sam0x17 merged commit 1047a72 into devnet-ready Mar 25, 2025
25 checks passed
This was referenced Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-cargo-audit This PR fails cargo audit but needs to be merged anyway
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants