Skip to content

Use last epoch hotkey alpha for fee calculation #1489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 1, 2025

Conversation

gztensor
Copy link
Contributor

Description

  • Use last epoch total hotkey alpha in staking fee calculation so that sharp changes in total hotkey alpha don't affect fees.
  • Also add TotalHotkeyAlphaLastEpoch, AlphaDividendsPerSubnet, and TaoDividendsPerSubnet to swap_hotkey.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gztensor gztensor added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Mar 31, 2025
sam0x17
sam0x17 previously approved these changes Mar 31, 2025
camfairchild
camfairchild previously approved these changes Mar 31, 2025
Copy link
Contributor

@camfairchild camfairchild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs tests:

  • unstaking with no prev epoch stake
  • unstaking with lower prev epoch stake than current stake

JohnReedV
JohnReedV previously approved these changes Apr 1, 2025
@gztensor gztensor dismissed stale reviews from JohnReedV and sam0x17 via cfe38a5 April 1, 2025 17:20
@sam0x17 sam0x17 requested a review from camfairchild April 1, 2025 21:05
@sam0x17 sam0x17 merged commit 3cfc000 into devnet-ready Apr 1, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-cargo-audit This PR fails cargo audit but needs to be merged anyway
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants