hotfix/set-root-weights #527
Merged
+296
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distributedstatemachine
requested review from
sam0x17,
camfairchild,
distributedstatemachine,
gztensor and
orriin
JohnReedV
requested review from
a team
and removed request for
sam0x17,
camfairchild,
distributedstatemachine,
gztensor and
orriin
sam0x17
previously approved these changes
Jun 13, 2024
open-junius
previously approved these changes
Jun 13, 2024
13 tasks
distributedstatemachine
dismissed stale reviews from open-junius and sam0x17
via
7408aca
sam0x17
previously approved these changes
Jun 13, 2024
|
we can merge it, PR in bittensor opentensor/bittensor#2021 will fix the failed test case. |
keithtensor
force-pushed
the
hotfix/set-root-weights
branch
from
4f8acd7 to
ef4b241
Compare
distributedstatemachine
previously approved these changes
Jun 14, 2024
camfairchild
approved these changes
Jun 14, 2024
camfairchild
previously requested changes
Jun 14, 2024
Co-authored-by: Cameron Fairchild <cameron@opentensor.ai>
Co-authored-by: Cameron Fairchild <cameron@opentensor.ai>
camfairchild
approved these changes
Jun 14, 2024
distributedstatemachine
approved these changes
Jun 14, 2024
sam0x17
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR hotfixes a bug that occurred when setting root weights. When checking if the caller had the minimum stake the coldkey was used rather than the hotkey.
{'code': 1010, 'message': 'Invalid Transaction', 'data': 'Transaction call is not expected'}TODO
BUMP SPEC VERSION