-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disabling all voice processing and filtering in custom audio driver #199
Comments
cc @msach22 if you can loop in any iOS folks that can assist. |
Hi, |
Hi @bstmobfriend105, no I have not changed the sample rate. I left it at:
which is defined as
|
There are known constraints to sample rates and formats inherited from both the WebRTC runtime and iOS. The rates chosen in the sample audio device are known working configurations, but not everything will work. The simulator needs to run at 44.1 kHz. Devices should stick between 8-32 kHz. |
@snobear Can you try setting the higher bitrate value on |
@bsrao sure I'll try that. For some reason I'm getting |
We're you able to fix this? Having same issue? |
@uma-speaks no I'm still getting I've opened another issue for this: #202 |
Hello,
We are having some issues with poor audio quality when playing instruments over Opentok. The suggestion in the React Native issue I opened was to implement the custom audio driver and use
kAudioUnitSubType_RemoteIO
only.We tested the Custom Audio Driver in this repo with the following results. Attached are Opentok Playground archive samples to illustrate the issues: archive-tests 2.zip
kAudioUnitSubType_VoiceProcessingIO
. Result: Bad overall qualitykAudioUnitSubType_RemoteIO
Result: Better quality, but being filtered (more on this below)kAudioUnitSubType_RemoteIO
and sets AVAudioSession tosetMode:AVAudioSessionModeMeasurement
in order to bypass the high-pass filter that is apparently still applied with RemoteIO (per https://stackoverflow.com/q/32227585/193210). (no difference in quality that I can tell from Initial Overlay-Graphics Cookbook sample OPENTOK-11524 #2).If you noticed with the
kAudioUnitSubType_RemoteIO
recordings, there is some sort of distortion and/or filter happening that makes higher ranges, e.g. the higher notes on the guitar sound poor. I'm wondering if someone could at least point me in the right direction on what to try next.I've tried messing with some of the stream_format settings, but things just get crazy sounding :). Thanks for any insight.
The text was updated successfully, but these errors were encountered: