If no document, omit "documents" key from DeviceResponse map #577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dyiop
commented
Apr 10, 2024
dyiop
commented
- Tests pass
- Appropriate changes to README are included in PR
davidz25
reviewed
Apr 10, 2024
| val deviceResponseGenerator = DeviceResponseGenerator(20) | ||
| val encodedDeviceResponse = deviceResponseGenerator.generate() | ||
|
|
||
| Assert.assertEquals(TestVectors.DEVICE_RESPONSE_NO_DOCUMENTS_STATUS_20.fromHex, encodedDeviceResponse) |
There was a problem hiding this comment.
Generally stuff in TestVectors.kt are the test vectors from Annex D. I think it would be cleaner to do
Assert.assertEquals("<insert pretty-printed-CBOR>", Cbor.toDiagnostics(encodedDeviceResponse, setOf(DiagnosticOption.PRETTY_PRINT)))
and then maybe add a comment above to say that there's no "documents" map entry.
There was a problem hiding this comment.
It's still using hex and not pretty-print...
…nse_if_no_docs_added' into omit_documents_from_device_response_if_no_docs_added
|
Ping. Also please squash all your commits into one when possible. |
This was referenced Jul 23, 2024
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.