Fixes for presentation during issuance workflow. #981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidz25
approved these changes
May 2, 2025
| ) | ||
| } | ||
| putJsonArray("claims") { | ||
| // TODO: support path-based claims, e.g. ["address", "postal_code"] |
There was a problem hiding this comment.
I think this comment can be removed here (and also in VerifierServlet.kt please)
| @@ -176,7 +229,7 @@ private fun calcClientMetadata(publicKey: EcPublicKey): JsonObject { | |||
| } | |||
| return buildJsonObject { | |||
| put("authorization_encrypted_response_alg", "ECDH-ES") | |||
| put("authorization_encrypted_response_enc", "A128CBC-HS256") | |||
| put("authorization_encrypted_response_enc", "A128GCM") | |||
There was a problem hiding this comment.
Algorithm.A128GCM.joseAlgorithmIdentifier might be nicer.
sorotokin
force-pushed
the
present-during-issuance
branch
from
aca22c6 to
d4e9e93
Compare
Minimal PR that brings presentation-during-issuance implementation to the current spec, in particular with DCQL. (More work will follow up to integrate PresentmentModel with the ProvisioningModel, in particular to select potentially matching credential(s) more intellegently). Testing: tested openid4vci issuance workflow with our own openid4vci server implementation. Signed-off-by: Peter Sorotokin <sorotokin@gmail.com>
sorotokin
force-pushed
the
present-during-issuance
branch
from
d4e9e93 to
30cfe22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimal PR that brings presentation-during-issuance implementation to the current spec, in particular with DCQL. (More work will follow up to integrate PresentmentModel with the ProvisioningModel, in particular to select potentially matching credential(s) more intellegently).
Testing: tested openid4vci issuance workflow with our own openid4vci server implementation.