Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vcdm 2.0 model and context #3436

Merged
merged 29 commits into from
Feb 26, 2025
Merged

Add vcdm 2.0 model and context #3436

merged 29 commits into from
Feb 26, 2025

Conversation

PatStLouis
Copy link
Contributor

Needs issuanceDate validation for vcdm 1.0 (add a current timestamp if absent)
Needs hooking up with didcomm

@PatStLouis
add vcdm 2.0 model and context
7ba9b99 
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
@PatStLouis PatStLouis requested review from dbluhm and jamshale January 10, 2025 19:43
@PatStLouis
add backwards compatibility checks: limit proof type and add issuance…
9879a4a 
… date with vcdm 1.1

Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
@PatStLouis
seperate test fixtures, lint
262ae0a 
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
@PatStLouis
replace issuanceDate tests
5951683 
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
ff137
ff137 reviewed Jan 10, 2025
View reviewed changes
Copy link
Contributor

@ff137 ff137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some early review comments

@dbluhm
Copy link
Contributor

dbluhm commented Jan 14, 2025

@PatStLouis I think it might be wise to get this "basic" support merged and then worry about integration with DIDComm ICv2 and PPv2 in a future PR.

@PatStLouis
Copy link
Contributor Author

@dbluhm I agree, I want at the minimum for the models not to break, since the didcomm protocols use the vc models

PatStLouis and others added 20 commits January 20, 2025 19:33
@PatStLouis
Merge branch 'openwallet-foundation:main' into vcdm-2.0-data-model-su…
909e187 
…pport
@PatStLouis
remove askar issuanceDate sorting
db5d959 
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
@PatStLouis
Merge branch 'vcdm-2.0-data-model-support' of github.com:OpSecId/arie…
b9a8049 
…s-cloudagent-python into vcdm-2.0-data-model-support
@PatStLouis
rename credential context constant
0025828 
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
@PatStLouis
linting
ede1d4b 
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
@PatStLouis
updated linting
19df824 
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
@PatStLouis
remove askar sorting step
41c7b14 
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
@PatStLouis
add vcdm 2.0 tests, fix presentation route default cryptosuite
a7c4243 
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
@PatStLouis
Fix broken tests, add v2 context to test document loader
286a18c 
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
@PatStLouis
Lint
12b8298 
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
@PatStLouis
Debugging unit tests
830201c 
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
@PatStLouis
Merge branch 'openwallet-foundation:main' into vcdm-2.0-data-model-su…
c46c816 
…pport
@PatStLouis
Merge branch 'vcdm-2.0-data-model-support' of github.com:OpSecId/arie…
efdd239 
…s-cloudagent-python into vcdm-2.0-data-model-support
@PatStLouis
rename test function to v2
c16c4a0 
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
@PatStLouis
add list of support cryptosuites for vcdm 2.0
2c09df6 
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
@PatStLouis
add list of supported cryptosuites for vcdm 2.0
2f17be3 
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
@PatStLouis
fix presentation fixture
a08d72c 
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
@PatStLouis
fix created format check
286d345 
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
@PatStLouis
fix tset fixtures
09d3d74 
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
@PatStLouis
lint
1cfe448 
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
@PatStLouis
add authentication proof purpose
1765caa 
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
@PatStLouis PatStLouis marked this pull request as ready for review January 27, 2025 21:55
@PatStLouis
Copy link
Contributor Author

@dbluhm ready for review

@PatStLouis PatStLouis requested a review from ff137 January 27, 2025 22:58
dbluhm
dbluhm reviewed Feb 6, 2025
View reviewed changes
Copy link
Contributor

@dbluhm dbluhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick comment but otherwise looks good

PatStLouis and others added 3 commits February 25, 2025 13:10
@PatStLouis
Merge branch 'main' into vcdm-2.0-data-model-support
0030342
@PatStLouis
add holder proof type derivation when creating a vp
4e0536a 
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
@PatStLouis
linting
7e26e37 
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 25, 2025 •
edited
Loading

Quality Gate Failed Quality Gate failed

Failed conditions
60.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@jamshale jamshale requested a review from dbluhm February 25, 2025 19:09
@jamshale jamshale merged commit e271c0d into openwallet-foundation:main Feb 26, 2025
10 of 11 checks passed
ff137 pushed a commit to didx-xyz/acapy that referenced this pull request Feb 27, 2025
@PatStLouis @ff137
Add vcdm 2.0 model and context (openwallet-foundation#3436)
d736a48 
* add vcdm 2.0 model and context

Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>

* add backwards compatibility checks: limit proof type and add issuance date with vcdm 1.1

Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>

* seperate test fixtures, lint

Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>

* replace issuanceDate tests

Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>

* remove askar issuanceDate sorting

Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>

* rename credential context constant

Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>

* linting

Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>

* updated linting

Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>

* remove askar sorting step

Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>

* add vcdm 2.0 tests, fix presentation route default cryptosuite

Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>

* Fix broken tests, add v2 context to test document loader

Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>

* Lint

Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>

* Debugging unit tests

Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>

* rename test function to v2

Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>

* add list of support cryptosuites for vcdm 2.0

Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>

* add list of supported cryptosuites for vcdm 2.0

Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>

* fix presentation fixture

Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>

* fix created format check

Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>

* fix tset fixtures

Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>

* lint

Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>

* add authentication proof purpose

Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>

* add holder proof type derivation when creating a vp

Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>

* linting

Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>

---------

Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
ff137 added a commit to didx-xyz/acapy that referenced this pull request Feb 27, 2025
@ff137
Revert "Add vcdm 2.0 model and context (openwallet-foundation#3436)"
9891db1 
This reverts commit d736a48.
ff137 pushed a commit to didx-xyz/acapy that referenced this pull request Feb 28, 2025
@PatStLouis @ff137
Add vcdm 2.0 model and context (openwallet-foundation#3436)
1d5c591 
* add vcdm 2.0 model and context

Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>

* add backwards compatibility checks: limit proof type and add issuance date with vcdm 1.1

Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>

* seperate test fixtures, lint

Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>

* replace issuanceDate tests

Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>

* remove askar issuanceDate sorting

Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>

* rename credential context constant

Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>

* linting

Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>

* updated linting

Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>

* remove askar sorting step

Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>

* add vcdm 2.0 tests, fix presentation route default cryptosuite

Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>

* Fix broken tests, add v2 context to test document loader

Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>

* Lint

Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>

* Debugging unit tests

Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>

* rename test function to v2

Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>

* add list of support cryptosuites for vcdm 2.0

Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>

* add list of supported cryptosuites for vcdm 2.0

Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>

* fix presentation fixture

Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>

* fix created format check

Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>

* fix tset fixtures

Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>

* lint

Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>

* add authentication proof purpose

Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>

* add holder proof type derivation when creating a vp

Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>

* linting

Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>

---------

Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbluhm dbluhm dbluhm approved these changes

@jamshale jamshale Awaiting requested review from jamshale

@ff137 ff137 Awaiting requested review from ff137

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PatStLouis @dbluhm @ff137 @jamshale