[tests] Made selenium test resilient to failures

Author: pandafy

openwisp_firmware_upgrader/tests/base.py

@@ -26,6 +26,7 @@ class TestUpgraderMixin(CreateConnectionsMixin):
     )
 
     def tearDown(self):
+        super().tearDown()
         for fw in FirmwareImage.objects.all():
             fw.delete()
 

openwisp_firmware_upgrader/tests/test_selenium.py

@@ -53,6 +53,7 @@ def setUp(self):
         )
 
     def tearDown(self):
+        super().tearDown()
         # Accept unsaved changes alert to allow other tests to run
         try:
             self.web_driver.refresh()
@@ -147,6 +148,11 @@ def save_device():
                 )
             )
         )
+        WebDriverWait(self.web_driver, 1).until(
+            EC.invisibility_of_element_located(
+                (By.CSS_SELECTOR, '#loading-overlay')
+            )
+        )
         # JSONSchema Editor should not be rendered without a change in the image field
         WebDriverWait(self.web_driver, 1).until(
             EC.invisibility_of_element_located(
@@ -275,6 +281,12 @@ def test_batch_upgrade_upgrade_options(self, *args):
         self.web_driver.find_element(
             by=By.CSS_SELECTOR, value='input[name="upgrade_all"]'
         ).click()
+        try:
+            WebDriverWait(self.web_driver, 5).until(
+                EC.url_contains('batchupgradeoperation')
+            )
+        except TimeoutException:
+            self.fail('User was not redirected to Mass upgrade operations page')
         self.assertEqual(
             BatchUpgradeOperation.objects.filter(
                 upgrade_options={
@@ -326,6 +338,9 @@ def test_upgrader_with_unsupported_upgrade_options(self, *args):
                     )
                 )
             )
+            WebDriverWait(self.web_driver, 5).until(
+                EC.visibility_of_element_located((By.ID, 'id_devicefirmware-0-image'))
+            )
             image_select = Select(
                 self.web_driver.find_element(
                     by=By.ID, value='id_devicefirmware-0-image'