[tests] Verify select is clickable

Author: pandafy

openwisp_firmware_upgrader/tests/test_selenium.py

@@ -97,6 +97,12 @@ def tearDown(self):
             EC.visibility_of_element_located((By.XPATH, '//*[@id="site-name"]'))
         )
 
+    def _get_device_firmware_dropdown_select(self):
+        select_element = WebDriverWait(self.web_driver, 5).until(
+            EC.element_to_be_clickable((By.ID, 'id_devicefirmware-0-image'))
+        )
+        return Select(select_element)
+
     @capture_any_output()
     def test_restoring_deleted_device(self):
         org = self._get_org()
@@ -136,8 +142,10 @@ def test_restoring_deleted_device(self):
                 f'admin:{self.config_app_label}_device_recover', args=[version_obj.id]
             )
         )
-        self.web_driver.find_element(
-            by=By.XPATH, value='//*[@id="device_form"]/div/div[1]/input[1]'
+        WebDriverWait(self.web_driver, 5).until(
+            EC.element_to_be_clickable(
+                (By.XPATH, '//*[@id="device_form"]/div/div[1]/input[1]')
+            )
         ).click()
         try:
             WebDriverWait(self.web_driver, 5).until(
@@ -150,7 +158,7 @@ def test_restoring_deleted_device(self):
         self.assertEqual(DeviceConnection.objects.count(), 1)
         self.assertEqual(DeviceFirmware.objects.count(), 1)
 
-    @capture_any_output()
+    # @capture_any_output()
     @patch(
         'openwisp_firmware_upgrader.upgraders.openwrt.OpenWrt.upgrade',
         return_value=True,
@@ -174,18 +182,13 @@ def save_device():
                 )
             )
         )
-        WebDriverWait(self.web_driver, 1).until(
-            EC.invisibility_of_element_located((By.CSS_SELECTOR, '#loading-overlay'))
-        )
         # JSONSchema Editor should not be rendered without a change in the image field
         WebDriverWait(self.web_driver, 1).until(
             EC.invisibility_of_element_located(
                 (By.CSS_SELECTOR, '#devicefirmware-group .jsoneditor-wrapper')
             )
         )
-        image_select = Select(
-            self.web_driver.find_element(by=By.ID, value='id_devicefirmware-0-image')
-        )
+        image_select = self._get_device_firmware_dropdown_select()
         image_select.select_by_value(str(image.pk))
         # JSONSchema configuration editor should not be rendered
         WebDriverWait(self.web_driver, 1).until(
@@ -238,9 +241,7 @@ def save_device():
                 (By.CSS_SELECTOR, '#devicefirmware-group .jsoneditor-wrapper')
             )
         )
-        image_select = Select(
-            self.web_driver.find_element(by=By.ID, value='id_devicefirmware-0-image')
-        )
+        image_select = self._get_device_firmware_dropdown_select()
         image_select.select_by_index(1)
         try:
             WebDriverWait(self.web_driver, 1).until(
@@ -362,14 +363,7 @@ def test_upgrader_with_unsupported_upgrade_options(self, *args):
                     )
                 )
             )
-            WebDriverWait(self.web_driver, 5).until(
-                EC.visibility_of_element_located((By.ID, 'id_devicefirmware-0-image'))
-            )
-            image_select = Select(
-                self.web_driver.find_element(
-                    by=By.ID, value='id_devicefirmware-0-image'
-                )
-            )
+            image_select = self._get_device_firmware_dropdown_select()
             image_select.select_by_value(str(image2.pk))
             # Ensure JSONSchema editor is not rendered because
             # the upgrader does not define a schema