Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[change] Check if user has notification enabled before prompting to verify email address #343

Open
nemesifier opened this issue Mar 21, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@nemesifier
Copy link
Member

Follow up of #281 / #336, to be done once we merge the gsoc24-rebased branch in master.

When a user logs in, if he doesn't have any verified email address we say that notifications are enabled and prompt to send the verification email again.

However, we aren't checking if the user really has any email notification enabled.
I think it would make sense to check this as not all users will care about email notifications and prompting them to verify their email address may be annoying for some.

I think we should:

  • Provide a method which checks whether the user has any email notification enabled
  • Use this method before checking if the user has any verified email in check_email_verification.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

1 participant