Mark num_outputs as out parameter in PJRT_Executable_OutputDimensions_Args Fixes #25211 #25657
+37
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le_OutputDimensions_Args - Annotate num_outputs in pjrt_c_api.h as /* out */ - Add C API test verifying num_outputs, dims, dim_sizes
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Im having some trouble with the CLA agreement it says an email contributed that, I will fix that and then redo it. |
jparkerh
approved these changes
Apr 25, 2025
| @@ -503,6 +503,59 @@ TEST_F(PjrtCApiTest, PluginAttributes) { | |||
| EXPECT_TRUE(names.find("stablehlo_minimum_version") != names.end()); | |||
| } | |||
|
|
|||
| TEST_F(PjrtCApiTest, ExecutableOutputDimensions) { | |||
There was a problem hiding this comment.
In c_api_test_base we have some helper functions to create a compiled executable (i.e. create_executable, l#295). Is it possible to remove some of the boilerplate at the top of test using some of those helpers?
grewalsk
force-pushed
the
fix/issue-25211-num-outputs-out-param
branch
from
97cd19b to
c134a92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #25211 by updating the C API header to explicitly mark num_outputs as an output parameter, clarifying the API contract. I also added a new C API test that calls GetOutputDimensions and verifies that num_outputs, dims and dim_sizes are correctly populated.