adds /controllers list to management and client API #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewpmartinez
force-pushed
the
add.controller.get
branch
from
ec92cdc to
898e6ab
Compare
andrewpmartinez
commented
Jan 17, 2024
| @@ -15,7 +15,7 @@ info: | |||
| license: | |||
There was a problem hiding this comment.
Focus on this file.
andrewpmartinez
commented
Jan 17, 2024
| @@ -15,7 +15,7 @@ info: | |||
| license: | |||
There was a problem hiding this comment.
Focus on this file.
andrewpmartinez
commented
Jan 17, 2024
| @@ -216,6 +216,8 @@ paths: | |||
| get: | |||
| security: | |||
| - ztSession: [] | |||
| - oauth2: | |||
| - openid | |||
There was a problem hiding this comment.
The OIDC was missing on these endpoints, causing OIDC bearer tokens to not work for auth.
dovholuknf
reviewed
Jan 17, 2024
dovholuknf
reviewed
Jan 17, 2024
| fooField2: def | ||
| causeMessage: schema validation failed | ||
| code: COULD_NOT_VALIDATE | ||
| message: The supplied request contains an invalid document |
There was a problem hiding this comment.
wording sounds off in some ways. "The supplied document is invalid" or "contains an invalid field"? or meh...
dovholuknf
reviewed
Jan 17, 2024
dovholuknf
reviewed
Jan 17, 2024
dovholuknf
reviewed
Jan 17, 2024
dovholuknf
reviewed
Jan 17, 2024
dovholuknf
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of this PR is generated. I added comments on the two main files that were changed.