-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove workarounds for controller / router helm charts #1047
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The router chart's README failed to render as a Docusaurus page w/ error:
ReferenceError: release is not defined
Could you trigger the test deploy again? Should be fixed now. This PR required the changes in openziti/helm-charts#298, but in that commit I only changed the documentation templates and did not run helm-docs to update the markdown files. That has happened now though with openziti/helm-charts#302 and openziti/helm-charts#301. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. The Vercel build still says
Error: Can't render static file for pathname "/docs/guides/deployments/kubernetes/kubernetes-controller"
Weird. A fresh checkout of this branch builds without error locally. I can only see yesterdays Vercel build, did it really run again? |
@jthurner I forgot to tell you this repo (and most ziti/rzok repos), require GitHub verified commits, which you can accomplish by signing with your GitHub-recognized PGP key. I can sign your commits into an upstream branch or you can amend w/ gpg-sign and force push to your fork. |
88f27cc
to
9ad678b
Compare
@qrkourier all set! |
As a result of a workaround with unescaped braces in the controller helm chart documentation, the docs currently render some garbled output:

This PR removes the workaround - depends on merging of openziti/helm-charts#298.