Release OpenProject 15.4.0

Author: machisuji

Diff for: .editorconfig

@@ -350,10 +350,7 @@ ij_json_spaces_within_brackets = false
 ij_json_wrap_long_lines = false
 
 [{rcov,spec,rake,rails,spork,capfile,gemfile,rakefile,guardfile,isolate,vagrantfile,Puppetfile,*.jbuilder,*.rbw,*.gemspec,*.thor,*.ru,*.rb,*.rake}]
-indent_size = 2
-tab_width = 2
 trim_trailing_whitespace=true
-ij_continuation_indent_size = 2
 ij_ruby_align_group_field_declarations = false
 ij_ruby_align_multiline_parameters = true
 ij_ruby_blank_lines_around_method = 1
@@ -364,7 +361,6 @@ ij_ruby_indent_protected_methods = false
 ij_ruby_indent_public_methods = false
 ij_ruby_indent_when_cases = false
 ij_ruby_keep_blank_lines_in_declarations = 2
-ij_ruby_keep_indents_on_empty_lines = false
 ij_ruby_keep_line_breaks = true
 ij_ruby_parentheses_around_method_arguments = true
 ij_ruby_spaces_around_hashrocket = true

Diff for: .erb-lint.yml renamed to .erb_lint.yml

@@ -15,6 +15,12 @@ linters:
     rubocop_config:
       inherit_from:
         - .rubocop.yml
+      Layout/CommentIndentation:
+        Enabled: false
+      Layout/FirstArgumentIndentation:
+        EnforcedStyle: consistent
+      Layout/FirstMethodArgumentLineBreak:
+        Enabled: true
       Layout/InitialIndentation:
         Enabled: false
       Layout/LeadingEmptyLines:
@@ -25,11 +31,13 @@ linters:
         Enabled: false
       Layout/TrailingWhitespace:
         Enabled: false
+      Lint/UselessAssignment:
+        Enabled: false
       Naming/FileName:
         Enabled: false
+      Rails/OutputSafety:
+        Enabled: true
       Style/FrozenStringLiteralComment:
         Enabled: false
-      Lint/UselessAssignment:
+      Style/RedundantConstantBase:
         Enabled: false
-      Rails/OutputSafety:
-        Enabled: true

Diff for: .github/dangerfiles/release_migrations/Dangerfile

@@ -0,0 +1,38 @@
+# frozen_string_literal: true
+
+#-- copyright
+# OpenProject is an open source project management software.
+# Copyright (C) the OpenProject GmbH
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License version 3.
+#
+# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
+# Copyright (C) 2006-2013 Jean-Philippe Lang
+# Copyright (C) 2010-2013 the ChiliProject Team
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+#
+# See COPYRIGHT and LICENSE files for more details.
+#++
+CORE_OR_MODULE_MIGRATIONS_REGEX = %r{(modules/.*)?db/migrate/.*\.rb}
+
+def added_or_modified_migrations
+  (git.modified_files + git.added_files).grep(CORE_OR_MODULE_MIGRATIONS_REGEX)
+end
+
+if github.branch_for_base.match?(/^release/) && added_or_modified_migrations.any?
+  warn "This PR has migration-related changes on a release branch. Ping @opf/operations"
+end

Diff for: .github/dangerfiles/user_references/Dangerfile

@@ -0,0 +1,80 @@
+# frozen_string_literal: true
+
+#-- copyright
+# OpenProject is an open source project management software.
+# Copyright (C) the OpenProject GmbH
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License version 3.
+#
+# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
+# Copyright (C) 2006-2013 Jean-Philippe Lang
+# Copyright (C) 2010-2013 the ChiliProject Team
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+#
+# See COPYRIGHT and LICENSE files for more details.
+#++
+
+MIGRATIONS_REGEX = %r{db/migrate/.*\.rb}
+USER_REFERENCE_REGEX = /(?:belongs_to\s+:user|references\s+:users?|to_table:\s*:users?|table_name:\s*["']users?["'])/i
+
+def added_or_modified_migrations?
+  (git.modified_files + git.added_files).grep(MIGRATIONS_REGEX)
+end
+
+def files_with_user_references
+  files = {}
+
+  # Check migrations
+  added_or_modified_migrations?.each do |file|
+    content = File.read(file)
+    if content.match?(USER_REFERENCE_REGEX)
+      files[file] = "migration with user reference"
+    end
+  end
+
+  files
+end
+
+# Check for user references in migrations and models
+files_with_references = files_with_user_references
+if files_with_references.any?
+  warning_message = ["Attention developer & reviewer: Files with potential user references found:"]
+
+  files_with_references.each do |file, type|
+    warning_message << "- #{file} (#{type})"
+  end
+
+  job_link = github.html_link("app/workers/principals/delete_job.rb")
+  replacement_service = github.html_link("app/services/principals/replace_references_service.rb")
+  replacements = github.html_link("config/initializers/replace_references_service.rb")
+
+  warning_message << <<~EOS
+
+  **Please make sure:**
+
+  1. You've added proper relationships (has_many, belongs_to, ...) and their inverse in your models
+  2. You deal with model destruction dependencies: `dependent: :destroy` or `dependent: :delete_all`
+  3. You add behavior and tests for the Principal::DeleteJob (#{job_link})
+  4. You replace references to users with deleted user in Principal::ReplaceReferencesService (#{replacement_service})  by adding to the replacements initailizer (#{replacements}) for the core, or using the `replace_principal_references` helper in modules/plugins.
+  5. You test the above behaviors with an integration test (e.g., [like this one](https://github.com/opf/openproject/blob/dev/modules/meeting/spec/services/principals/replace_references_service_call_integration_spec.rb) to confirm deletion of users is possible.
+
+  This helps prevent dangling database objects when users are deleted and resulting bugs.
+  EOS
+
+
+  warn warning_message.join("\n")
+end

Diff for: .github/dependabot.yml

@@ -21,6 +21,10 @@ updates:
     target-branch: "dev"
     open-pull-requests-limit: 3
     versioning-strategy: lockfile-only
+    groups:
+      aws-gems:
+        patterns:
+          - "aws-*"
   - package-ecosystem: "github-actions"
     directory: "/"
     schedule:

Diff for: .github/workflows/danger.yml

@@ -1,12 +1,13 @@
-name: migration-warning-on-release-branches
+name: Dangerfile
 
 on:
   pull_request:
-    branches:
-      - release/*
-    paths:
-      - 'db/migrate/**.rb'
-      - 'modules/**/db/migrate/*.rb'
+    types: [opened, reopened, synchronize]
+    paths-ignore:
+      - 'docs/**'
+      - 'help/**'
+      - 'packaging/**'
+      - '.pkgr.yml'
 
 jobs:
   danger:
@@ -15,12 +16,17 @@ jobs:
     timeout-minutes: 10
     steps:
       - uses: actions/checkout@v4
-      - uses: ruby/setup-ruby@v1
         with:
-          ruby-version: '3.4.1'
-      - uses: MeilCli/danger-action@v6
+          fetch-depth: 0
+      - uses: ruby/setup-ruby@v1
         with:
-          danger_file: 'Dangerfile'
-          danger_id: 'danger-pr'
+          ruby-version: .ruby-version
+          bundler-cache: true
+      - name: Setup danger
+        run: |
+          gem install danger
+      - name: Run inconsistent translations check
         env:
           DANGER_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: |
+          danger --verbose

Diff for: .github/workflows/docker.yml

@@ -133,11 +133,6 @@ jobs:
             bim_support: false
             target: all-in-one
             runner: runner=4cpu-linux-arm64
-          - platform: linux/ppc64le
-            digest: ppc-aio
-            bim_support: false
-            target: all-in-one
-            runner: runner=4cpu-linux-x64
     steps:
       - name: Checkout
         uses: actions/checkout@v4

Diff for: .rubocop.yml

@@ -1,17 +1,18 @@
 require:
   - rubocop-openproject
-  - rubocop-rails
-  - rubocop-rspec
   - rubocop-rspec_rails
   - rubocop-capybara
   - rubocop-factory_bot
-  - rubocop-performance
   - ./config/initializers/inflections.rb
 
-<% if File.exist?('.rubocop-local.yml') %>
+plugins:
+  - rubocop-rails
+  - rubocop-rspec
+  - rubocop-performance
+
+# A rubocop-local.yml file can be added to customized the styles
 inherit_from:
-  - .rubocop-local.yml
-<% end %>
+  - .rubocop-local*.yml
 
 inherit_mode:
   merge:

Diff for: .ruby-version

@@ -1 +1 @@
-3.4.1
+3.4.2

Diff for: Dangerfile

@@ -1,9 +1,31 @@
-CORE_OR_MODULE_MIGRATIONS_REGEX = %r{(modules/.*)?db/migrate/.*\.rb}
+# frozen_string_literal: true
 
-def added_or_modified_migrations?
-  (git.modified_files + git.added_files).grep(CORE_OR_MODULE_MIGRATIONS_REGEX)
-end
-
-if added_or_modified_migrations?
-  warn "This PR has migration-related changes on a release branch. Ping @opf/operations"
-end
+#-- copyright
+# OpenProject is an open source project management software.
+# Copyright (C) the OpenProject GmbH
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License version 3.
+#
+# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
+# Copyright (C) 2006-2013 Jean-Philippe Lang
+# Copyright (C) 2010-2013 the ChiliProject Team
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+#
+# See COPYRIGHT and LICENSE files for more details.
+#++
+danger.import_dangerfile(path: ".github/dangerfiles/user_references/Dangerfile")
+danger.import_dangerfile(path: ".github/dangerfiles/release_migrations/Dangerfile")