Validate scopes of JWTs #18393
Merged
Validate scopes of JWTs #18393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Keeping this PR as a draft until we decided whether we need to temporarily disable this check for APIv3 specifically or not. |
NobodysNightmare
force-pushed
the
validate-scopes
branch
2 times, most recently
from
9e0f0a1 to
ef65ef5
Compare
So far we are only accepting JWTs for requests to APIv3 and our scopes are not more fine-grained than that. However, warden strategies are generally responsible for validating the scopes of a token (e.g. compare DoorkeeperOAuth) to the scope of the currently accessed API.
NobodysNightmare
force-pushed
the
validate-scopes
branch
from
ef65ef5 to
5206187
Compare
Kharonus
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far we are only accepting JWTs for requests to
APIv3 and our scopes are not more fine-grained than that.
However, warden strategies are generally responsible for validating
the scopes of a token (e.g. compare DoorkeeperOAuth) to the scope
of the currently accessed API.
Ticket
https://community.openproject.org/wp/62360
Merge checklist