Skip to content

[#61889] Primerize Project create and settings > Information forms #18478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

myabc
Copy link
Contributor

@myabc myabc commented Mar 28, 2025

Ticket

https://community.openproject.org/wp/61889

What are you trying to accomplish?

Screenshots

What approach did you choose and why?

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@myabc myabc requested a review from Copilot March 28, 2025 14:34
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the project creation interface by replacing an Angular component with native form helpers and introduces a dedicated project form as part of the project creation process. It also updates the controller logic to support creating subprojects.

  • Replaced the Angular component in the new project view with a primer form block.
  • Introduced a new Projects::Form for handling project-specific input fields.
  • Updated the new action in ProjectsController to create project instances based on the parent project if provided.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
app/views/projects/new.html.erb Replaced angular component usage with a primer form block rendering.
app/forms/projects/form.rb Added a new form for project creation with custom fields.
app/controllers/projects_controller.rb Modified new action to handle subproject instantiation.
Comments suppressed due to low confidence (1)

app/views/projects/new.html.erb:39

  • [nitpick] The wrapper_id 'FOO' appears to be a placeholder value. Consider using a descriptive identifier to better reflect its purpose.
concat render(Projects::CustomFields::Form.new(f, project: @project, wrapper_id: "FOO"))

@myabc myabc force-pushed the feature/61889-primerize-project-forms branch 3 times, most recently from 7f2468c to 54acac6 Compare April 4, 2025 14:47
@myabc myabc force-pushed the feature/61889-primerize-project-forms branch 5 times, most recently from cb3cc93 to 94acd02 Compare April 8, 2025 15:41
@myabc myabc force-pushed the feature/61889-primerize-project-forms branch 4 times, most recently from 43f665a to b38d3b7 Compare April 16, 2025 19:47
@myabc myabc force-pushed the feature/61889-primerize-project-forms branch from b38d3b7 to 3773048 Compare April 17, 2025 16:17
@myabc myabc force-pushed the feature/61889-primerize-project-forms branch from 3773048 to cdae622 Compare April 17, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant