-
Notifications
You must be signed in to change notification settings - Fork 2.6k
[#61889] Primerize Project create and settings > Information forms #18478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the project creation interface by replacing an Angular component with native form helpers and introduces a dedicated project form as part of the project creation process. It also updates the controller logic to support creating subprojects.
- Replaced the Angular component in the new project view with a primer form block.
- Introduced a new Projects::Form for handling project-specific input fields.
- Updated the new action in ProjectsController to create project instances based on the parent project if provided.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
File | Description |
---|---|
app/views/projects/new.html.erb | Replaced angular component usage with a primer form block rendering. |
app/forms/projects/form.rb | Added a new form for project creation with custom fields. |
app/controllers/projects_controller.rb | Modified new action to handle subproject instantiation. |
Comments suppressed due to low confidence (1)
app/views/projects/new.html.erb:39
- [nitpick] The wrapper_id 'FOO' appears to be a placeholder value. Consider using a descriptive identifier to better reflect its purpose.
concat render(Projects::CustomFields::Form.new(f, project: @project, wrapper_id: "FOO"))
7f2468c
to
54acac6
Compare
cb3cc93
to
94acd02
Compare
43f665a
to
b38d3b7
Compare
`aria-labelledby` should reference the original field's label, not the original field (`textarea`).
b38d3b7
to
3773048
Compare
3773048
to
cdae622
Compare
Ticket
https://community.openproject.org/wp/61889
What are you trying to accomplish?
Screenshots
What approach did you choose and why?
Merge checklist