Use component for global and project definition administration #18522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulferts
force-pushed
the
implementation/62709-use-projectlifecyclecomponent-on-project-and-global-administration
branch
from
37d6ae4 to
a1cb5b9
Compare
This comment was marked as outdated.
This comment was marked as outdated.
dombesz
approved these changes
Apr 4, 2025
Comment on lines
34
to
37
| # TODO: This component is currently not in use! It should be a shared component | ||
| # between the Projects::Settings::LifeCycleSteps::StepComponent and the | ||
| # Settings::ProjectLifeCycleStepDefinitions::RowComponent. | ||
| # It should hold the icon, definition name and gate text information. |
There was a problem hiding this comment.
I think this comment is not relevant anymore.
Suggested change
| # TODO: This component is currently not in use! It should be a shared component | |
| # between the Projects::Settings::LifeCycleSteps::StepComponent and the | |
| # Settings::ProjectLifeCycleStepDefinitions::RowComponent. | |
| # It should hold the icon, definition name and gate text information. |
| Projects::PhaseDefinitionComponent.new( | ||
| definition, | ||
| edit_link: User.current.admin?, | ||
| phase_text_options: { classes: "filter-target-visible-text" } |
There was a problem hiding this comment.
I like how the "filter-target-visible-text" is logically separated to be context aware, but I'm unsure if it is required, because we seem to use in all the instances. Do you think we will use this component without the "filter-target-visible-text" in the future?
There was a problem hiding this comment.
@dombesz I don't know. I just felt that it is not the responsibility of that component to be ready to be filterable with that controller.
ulferts
deleted the
implementation/62709-use-projectlifecyclecomponent-on-project-and-global-administration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/62709
What are you trying to accomplish?
Use a common component on both the global as well as the project specific administration to render the information about the project phase definition:
There shouldn't be visible changes.