[#62386] Project attribute list entries not displayed when applied as filter in project list

[dombesz]

Ticket

https://community.openproject.org/work_packages/62386

What are you trying to accomplish?

Load the autocompleter values of project filters from saved queries. Additionally, fix 4 flaky specs by using synchronous matchers instead of asynchronous ones.

What approach did you choose and why?

The solution consists of 2 parts:

• Fix the change detection mechanism of the autocompleter to pick up the selected value.
• Fix the additional attribute computation to use the active filters whenever is possible in order to retrieve the values from the saved project queries.

The flaky specs fixed:

'./spec/features/work_packages/custom_actions/custom_actions_spec.rb:316'
'./spec/features/work_packages/details/milestones_spec.rb:48'
'./modules/boards/spec/features/action_boards/status_type_moving_board_spec.rb:112'
'./spec/features/notifications/notification_center/split_screen_spec.rb:55'
'./spec/features/types/form_configuration_query_spec.rb:174'

Merge checklist

• Added/updated tests
• Added/updated documentation in Lookbook (patterns, previews, etc)
• Tested major browsers (Chrome, Firefox, Edge, ...)

[github-actions]

Caution

The provided work package version does not match the core version

Details:

• Work package URL: https://community.openproject.org/work_packages/62386
• Work package version: not set
• Core version: 16.0.0

Please make sure that:

• The work package version OR your pull request target branch is correct

[dombesz]

@myabc Can I ask you kindly to check whether this testcase is still valid. The component has changed a bit, which causes the spec to fail. Thank you!

[ulferts]

The values now show up and I really appreciate you removing duplicated methods, @dombesz.

So I feel bad telling you that there still appears to be a bug in here. I didn't look into the why but this is how to reproduce it:

• Have two list custom fields
• Save a query with one of those custom fields as a filter
• After saving, add the second custom field as a filter.
• Try to save.

The former filter seems to not have its value set thoroughly so the saving fails.

[ulferts]

👍 for cleaning up the duplicated methods. I wasn't aware of those. How about we open a code maintenance ticket to move even more over to the module, e.g. date_time_filter? but also the set_advanced_filter method?

[dombesz]

The values now show up and I really appreciate you removing duplicated methods, @dombesz.

So I feel bad telling you that there still appears to be a bug in here. I didn't look into the why but this is how to reproduce it:

• Have two list custom fields
• Save a query with one of those custom fields as a filter
• After saving, add the second custom field as a filter.
• Try to save.

The former filter seems to not have its value set thoroughly so the saving fails.

Thanks @ulferts, I bumped into this bug earlier and according to my investigations, it is not a related bug. However since I'm already doing this bugfix, I would solve the issue in this PR.