Rework "open storage" action #18566
Open
Rework "open storage" action #18566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NobodysNightmare
force-pushed
the
feature/62758-storage-sidebar-button-in-projects-should-behave-correctly-in-all-scenarios
branch
5 times, most recently
from
b0e8b17 to
01bc9f1
Compare
NobodysNightmare
force-pushed
the
feature/62758-storage-sidebar-button-in-projects-should-behave-correctly-in-all-scenarios
branch
5 times, most recently
from
b489677 to
3f4d477
Compare
NobodysNightmare
requested review from
Kharonus and
mereghost
and removed request for
Kharonus
NobodysNightmare
changed the title
|
Opening this PR for review already. Relevant tests are passing. The only thing left is that I need to split tests for code that I separated (currently the original unit tests cover the extracted concerns). |
NobodysNightmare
force-pushed
the
feature/62758-storage-sidebar-button-in-projects-should-behave-correctly-in-all-scenarios
branch
from
3f4d477 to
268c9e1
Compare
The previous implementation was a deeply nested decision tree for different error cases or other unexpected states. Most of this was necessary, because setting up correct permissions is partially happening asynchronously. Some of the redirects would eventually have rendered a modal that would periodically check whether user permissions appeared in the background. All of this was replaced by an approach where we immediately (synchronously) ensure that the setup is correct.
NobodysNightmare
force-pushed
the
feature/62758-storage-sidebar-button-in-projects-should-behave-correctly-in-all-scenarios
branch
from
268c9e1 to
da9666d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation was a deeply nested decision tree for different error cases or other unexpected states.
Most of this was necessary, because setting up correct permissions is partially happening asynchronously. Some of the redirects would eventually have rendered a modal that would periodically check whether user permissions appeared in the background.
All of this was replaced by an approach where we immediately (synchronously) ensure that the setup is correct.
Ticket
https://community.openproject.org/wp/62758
Merge checklist