remove WorkPackagePolicy #18614
Merged
remove WorkPackagePolicy #18614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulferts
force-pushed
the
code_maintenance/remove_work_package_policy
branch
5 times, most recently
from
3d077de to
9e01f62
Compare
ulferts
force-pushed
the
code_maintenance/remove_work_package_policy
branch
from
9e01f62 to
da2efde
Compare
klaustopher
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/63458
What are you trying to accomplish?
This started off as a code maintenance ticket. But while on it, a missing permission check was discovered which is now added in this PR as well. That permission check is for
add_comments_with_restricted_visibilityin theWorkPackages::CreateNoteContract.The
WorkPackagePolicyclass no longer offers an advantage over simply callinguser.allowed_to_in_project?other than providing an abstraction layer that hides the implementation details. Since the rest of the implementation has by now moved to contracts, this however requires the dev to still look into the class to understand what it is doing as it is an outlier in the code.There exist two other policies that are not touched by this. They can be removed independently.