Fix code review failures

oracle · Feb 26, 2025 · cbc7473 · cbc7473
1 parent bce5c0f
commit cbc7473
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 5 deletions.
diff --git a/...e-operator/src/main/java/com/oracle/coherence/k8s/CoherenceOperatorLifecycleListener.java b/...e-operator/src/main/java/com/oracle/coherence/k8s/CoherenceOperatorLifecycleListener.java
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2021, 2023, Oracle and/or its affiliates.
+ * Copyright (c) 2021, 2025, Oracle and/or its affiliates.
  * Licensed under the Universal Permissive License v 1.0 as shown at
  * http://oss.oracle.com/licenses/upl.
  */
@@ -292,7 +292,8 @@ void initCohCtl() {
             }
 
             // If we have a COHCTL_HOME env var or property try to create the config there
-            if (cohCtlHome != null && !cohCtlHome.isEmpty() && tryCreateConfig(new File(cohCtlHome), connectionType, protocol, port, clusterName)) {
+            if (cohCtlHome != null && !cohCtlHome.isEmpty()
+                && tryCreateConfig(new File(cohCtlHome), connectionType, protocol, port, clusterName)) {
                 return;
             }
 
@@ -313,10 +314,12 @@ void initCohCtl() {
                 }
                 else {
                     if (!fileCohCtlHome.exists()) {
-                        LOGGER.error("CoherenceOperator: Cannot create cohctl config, directory " + fileCohCtlHome + " does not exist");
+                        LOGGER.error("CoherenceOperator: Cannot create cohctl config, directory "
+                                             + fileCohCtlHome + " does not exist");
                     }
                     else {
-                        LOGGER.error("CoherenceOperator: Cannot create cohctl config, location " + fileCohCtlHome + " is not a directory");
+                        LOGGER.error("CoherenceOperator: Cannot create cohctl config, location "
+                                             + fileCohCtlHome + " is not a directory");
                     }
                 }
             }
@@ -334,6 +337,17 @@ void initCohCtl() {
         }
     }
 
+    /**
+     * Try to create the Coherence CLI configuration.
+     *
+     * @param home            the location of the CLI home directory
+     * @param connectionType  the type of the connection http or https
+     * @param protocol        the protocol for the connection http or https
+     * @param port            the management over REST port
+     * @param clusterName     the cluster name
+     *
+     * @return {@code true} of the configuration was created
+     */
     protected boolean tryCreateConfig(File home, String connectionType, String protocol, String port, String clusterName) {
         File configFile = new File(home, "cohctl.yaml");
 

diff --git a/runner/main.go b/runner/main.go
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2020, 2022, Oracle and/or its affiliates.
+ * Copyright (c) 2020, 2025, Oracle and/or its affiliates.
  * Licensed under the Universal Permissive License v 1.0 as shown at
  * http://oss.oracle.com/licenses/upl.
  */