svm: move @BasedOnJDKFile annotation to constructor [GR-59171]

Author: zapster

substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/attach/AttachListenerThread.java

@@ -44,7 +44,6 @@
  * A dedicated listener thread that accepts client connections and that handles diagnostic command
  * requests. At the moment, only jcmd is supported.
  */
-@BasedOnJDKFile("https://github.com/openjdk/jdk/blob/jdk-24+18/src/hotspot/share/services/attachListener.cpp#L453-L467")
 public abstract class AttachListenerThread extends Thread {
     private static final String JCMD_COMMAND_STRING = "jcmd";
     @BasedOnJDKFile("https://github.com/openjdk/jdk/blob/jdk-24+18/src/hotspot/share/services/attachListener.hpp#L142") //
@@ -55,7 +54,7 @@ public abstract class AttachListenerThread extends Thread {
     protected static final int ARG_COUNT_MAX = 3;
 
     @SuppressWarnings("this-escape")
-    // This constructor should be annotated with @BasedOnJDK instead of the class, see GR-59171.
+    @BasedOnJDKFile("https://github.com/openjdk/jdk/blob/jdk-24+18/src/hotspot/share/services/attachListener.cpp#L453-L467")
     public AttachListenerThread() {
         super(PlatformThreads.singleton().systemGroup, "Attach Listener");
         this.setDaemon(true);

substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/dcmd/JfrCheckDCmd.java

@@ -35,10 +35,9 @@
 import com.oracle.svm.core.jfr.Target_jdk_jfr_internal_dcmd_AbstractDCmd;
 import com.oracle.svm.core.util.BasedOnJDKFile;
 
-@BasedOnJDKFile("https://github.com/openjdk/jdk/blob/jdk-24+18/src/hotspot/share/jfr/dcmd/jfrDcmds.hpp#L106-L108")
 public class JfrCheckDCmd extends AbstractJfrDCmd {
-    // This constructor should be annotated with @BasedOnJDK instead of the class, see GR-59171.
     @Platforms(Platform.HOSTED_ONLY.class)
+    @BasedOnJDKFile("https://github.com/openjdk/jdk/blob/jdk-24+18/src/hotspot/share/jfr/dcmd/jfrDcmds.hpp#L106-L108")
     public JfrCheckDCmd() {
         super("JFR.check", "Checks running JFR recording(s)", Impact.Low);
     }

substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/dcmd/JfrDumpDCmd.java

@@ -35,10 +35,9 @@
 import com.oracle.svm.core.jfr.Target_jdk_jfr_internal_dcmd_AbstractDCmd;
 import com.oracle.svm.core.util.BasedOnJDKFile;
 
-@BasedOnJDKFile("https://github.com/openjdk/jdk/blob/jdk-24+18/src/hotspot/share/jfr/dcmd/jfrDcmds.hpp#L81-L83")
 public class JfrDumpDCmd extends AbstractJfrDCmd {
-    // This constructor should be annotated with @BasedOnJDK instead of the class, see GR-59171.
     @Platforms(Platform.HOSTED_ONLY.class)
+    @BasedOnJDKFile("https://github.com/openjdk/jdk/blob/jdk-24+18/src/hotspot/share/jfr/dcmd/jfrDcmds.hpp#L81-L83")
     public JfrDumpDCmd() {
         super("JFR.dump", "Copies contents of a JFR recording to file. Either the name or the recording id must be specified.", Impact.Medium);
     }

substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/dcmd/JfrStartDCmd.java

@@ -34,10 +34,9 @@
 import com.oracle.svm.core.jfr.Target_jdk_jfr_internal_dcmd_DCmdStart;
 import com.oracle.svm.core.util.BasedOnJDKFile;
 
-@BasedOnJDKFile("https://github.com/openjdk/jdk/blob/jdk-24+18/src/hotspot/share/jfr/dcmd/jfrDcmds.hpp#L56-L58")
 public class JfrStartDCmd extends AbstractJfrDCmd {
-    // This constructor should be annotated with @BasedOnJDK instead of the class, see GR-59171.
     @Platforms(Platform.HOSTED_ONLY.class)
+    @BasedOnJDKFile("https://github.com/openjdk/jdk/blob/jdk-24+18/src/hotspot/share/jfr/dcmd/jfrDcmds.hpp#L56-L58")
     public JfrStartDCmd() {
         super("JFR.start", "Starts a new JFR recording.", Impact.Medium);
     }

substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/dcmd/JfrStopDCmd.java

@@ -35,10 +35,9 @@
 import com.oracle.svm.core.jfr.Target_jdk_jfr_internal_dcmd_AbstractDCmd;
 import com.oracle.svm.core.util.BasedOnJDKFile;
 
-@BasedOnJDKFile("https://github.com/openjdk/jdk/blob/jdk-24+18/src/hotspot/share/jfr/dcmd/jfrDcmds.hpp#L131-L133")
 public class JfrStopDCmd extends AbstractJfrDCmd {
-    // This constructor should be annotated with @BasedOnJDK instead of the class, see GR-59171.
     @Platforms(Platform.HOSTED_ONLY.class)
+    @BasedOnJDKFile("https://github.com/openjdk/jdk/blob/jdk-24+18/src/hotspot/share/jfr/dcmd/jfrDcmds.hpp#L131-L133")
     public JfrStopDCmd() {
         super("JFR.stop", "Stops a JFR recording.", Impact.Low);
     }

substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/dcmd/VMNativeMemoryDCmd.java

@@ -32,15 +32,14 @@
 import com.oracle.svm.core.nmt.NativeMemoryTracking;
 import com.oracle.svm.core.util.BasedOnJDKFile;
 
-@BasedOnJDKFile("https://github.com/openjdk/jdk/blob/jdk-24+18/src/hotspot/share/nmt/nmtDCmd.hpp#L49-L52")
-@BasedOnJDKFile("https://github.com/openjdk/jdk/blob/jdk-24+18/src/hotspot/share/nmt/nmtDCmd.cpp#L34-L64")
 public class VMNativeMemoryDCmd extends AbstractDCmd {
     private static final DCmdOption<Boolean> SUMMARY = new DCmdOption<>(Boolean.class, "summary",
                     "Request runtime to report current memory summary, which includes total reserved and committed memory, along with memory usage summary by each subsystem.",
                     false, false);
 
-    // This constructor should be annotated with @BasedOnJDK instead of the class, see GR-59171.
     @Platforms(Platform.HOSTED_ONLY.class)
+    @BasedOnJDKFile("https://github.com/openjdk/jdk/blob/jdk-24+18/src/hotspot/share/nmt/nmtDCmd.hpp#L49-L52")
+    @BasedOnJDKFile("https://github.com/openjdk/jdk/blob/jdk-24+18/src/hotspot/share/nmt/nmtDCmd.cpp#L34-L64")
     public VMNativeMemoryDCmd() {
         super("VM.native_memory", "Print native memory usage", Impact.Low, new DCmdOption<?>[0], new DCmdOption<?>[]{SUMMARY},
                         new String[]{"$ jcmd <pid> VM.native_memory summary"});