Refactor for clean code

Author: jormundur00

vm/tests/gh_workflows/NILayerTests/build_native_image_layer.py

@@ -48,10 +48,15 @@ def generate_matrix(path_to_data, libs_per_job, delimiter):
     '''
     Generates a matrix in the format of GAV coordinate tuples (depending on the selected number of libraries per action job) for GitHub actions.
     '''
-    with open(os.path.join(path_to_data, 'popular-maven-libraries.json'), 'r') as f:
-        data = json.load(f)
-    with open(os.path.join(path_to_data, 'excluded-popular-maven-libraries.json'), 'r') as f:
-        exclude_data = json.load(f)
+    try:
+        with open(os.path.join(path_to_data, 'popular-maven-libraries.json'), 'r') as f:
+            data = json.load(f)
+        with open(os.path.join(path_to_data, 'excluded-popular-maven-libraries.json'), 'r') as f:
+            exclude_data = json.load(f)
+    except (FileNotFoundError, json.JSONDecodeError) as e:
+        print(f"Error loading files: {e}")
+        sys.exit(1)
+
     matrix = {'coordinates': []}
     excluded_coordinates = {f'{lib['group_id']}:{lib['artifact_id']}:{lib['version']}' for lib in exclude_data}
     libs_in_job = []
@@ -67,11 +72,14 @@ def generate_matrix(path_to_data, libs_per_job, delimiter):
     if len(libs_in_job) > 0:
         matrix['coordinates'].append(delimiter.join(libs_in_job))
 
-    try:    
-        with open(os.environ['GITHUB_OUTPUT'], 'a') as f:
-            print(f"matrix={json.dumps(matrix)}", file=f)
-    except IOError:
-        print("Error: Failed opening GITHUB_OUTPUT. Stopping action...")
+    try:
+        github_output = os.getenv('GITHUB_OUTPUT')
+        if github_output is None:
+            raise EnvironmentError("GITHUB_OUTPUT environment variable not set")
+        with open(github_output, 'a') as f:
+            f.write(f"matrix={json.dumps(matrix)}\n")
+    except (IOError, EnvironmentError) as e:
+        print(f"Error writing to GITHUB_OUTPUT: {e}")
         sys.exit(1)
 
 def build_layers(native_image_path, coordinates, delimiter):
@@ -87,12 +95,13 @@ def build_layers(native_image_path, coordinates, delimiter):
     for gav in coordinates_list:
         currDir = os.getcwd()
         group_id, artifact_id, version = gav.split(':')
+
         subprocess.run(['mvn', 'dependency:get', f'-Dartifact={gav}', '-Dtransitive=true'])
 
-        home_path = str(Path.home())
-        library_path = os.path.join(home_path, '.m2', 'repository', group_id.replace('.','/'), artifact_id, version)
+        library_path = os.path.join(Path.home(), '.m2', 'repository', group_id.replace('.','/'), artifact_id, version)
         jar_path = os.path.join(library_path, f'{artifact_id}-{version}.jar')
         subprocess.run(['cp', f'{os.path.join(library_path, f'{artifact_id}-{version}.pom')}', f'{os.path.join(library_path, 'pom.xml')}'])
+
         if Path(library_path).exists():
             subprocess.run(['mkdir', gav])
             os.chdir(gav)
@@ -104,6 +113,7 @@ def build_layers(native_image_path, coordinates, delimiter):
             subprocess.run(command)
             print(f'Command: {' '.join(command)}')
             os.chdir('..')
+            
         os.chdir(currDir)
 
 if __name__ == '__main__':