[GR-60873] TRegex: fix corner cases in NFATraversalRegexASTVisitor.

PullRequest: graal/19742

Author: djoooooe

regex/src/com.oracle.truffle.regex.test/src/com/oracle/truffle/regex/tregex/test/JsTests.java

@@ -542,6 +542,8 @@ public void generatedTests() {
         expectSyntaxError("[--a]", "v", "", getTRegexEncoding(), "empty", 0, ErrorCode.InvalidCharacterClass);
         test("(?:^\\1|$){10,11}bc", "", "aaaaaabc", 0, false);
         test("a(?:|[0-9]+?a|[0-9a]){11,13}?[ab]", "", "a372a466a109585878b", 0, true, 0, 5);
+        test("(?<=ab(?:c|$){8,8})", "", "abccccc", 0, true, 7, 7);
+        test("(?:^a|$){1,72}a", "", "aaaaaaaa", 0, true, 0, 2);
 
         /* GENERATED CODE END - KEEP THIS MARKER FOR AUTOMATIC UPDATES */
     }

regex/src/com.oracle.truffle.regex.test/src/com/oracle/truffle/regex/tregex/test/PythonTests.java

@@ -846,6 +846,7 @@ public void generatedTests() {
         test("[\\W]", "i", "\u0399", 0, false);
         test("(\\Aa)+?|(?<=ab\\1)", "", "empty", 0, false);
         test("^([c-l])\\1|(\\A\\1)+", "", "kk", 0, true, 0, 2, 0, 1, -1, -1, 1);
+        test("(?:\\Z|\\Aa){1,44}a", "", "aaaa", 0, true, 0, 2, -1);
 
         /* GENERATED CODE END - KEEP THIS MARKER FOR AUTOMATIC UPDATES */
     }

regex/src/com.oracle.truffle.regex/src/com/oracle/truffle/regex/tregex/parser/ast/visitors/NFATraversalRegexASTVisitor.java

@@ -573,7 +573,7 @@ private boolean advanceTerm(Term term) {
                 if (!getFlavor().emptyChecksOnMandatoryLoopIterations() &&
                                 curGroup.isMandatoryQuantifier() &&
                                 !curGroup.isExpandedQuantifier() &&
-                                (!ast.getOptions().isBooleanMatch() || ast.getProperties().hasBackReferences() || caretsOnPath())) {
+                                (!ast.getOptions().isBooleanMatch() || ast.getProperties().hasBackReferences() || caretsOnPath() || isReverse() && dollarsOnPath())) {
                     // the existence of a mandatory copy of the quantifier loop implies a minimum
                     // greater than zero
                     assert !curGroup.isMandatoryQuantifier() || quantifier.getMin() > 0;
@@ -1076,7 +1076,7 @@ private void calculateTransitionGuards() {
                     Quantifier quantifier = quantifierGroup.getQuantifier();
                     if (!quantifierGroup.isExpandedQuantifier()) {
                         if (quantifierGroup.isDead()) {
-                            if (quantifier.getMin() > 0) {
+                            if (quantifier.getMin() > 0 && !quantifierGroup.isOptionalQuantifier()) {
                                 setShouldRetreat();
                             }
                         } else if (quantifier.hasIndex()) {