[GR-64154] Prevent pointless stack walking during LogRecord marshalling.

PullRequest: graal/20524

Author: jchalou

truffle/src/com.oracle.truffle.api/src/com/oracle/truffle/api/impl/Accessor.java

@@ -762,6 +762,12 @@ public abstract <T, G> Iterator<T> mergeHostGuestFrames(Object polyglotEngine, S
 
         public abstract String getFormatKind(LogRecord logRecord);
 
+        public abstract boolean isLogRecordCallerClassSet(LogRecord logRecord);
+
+        public abstract boolean isLogRecordCallerMethodSet(LogRecord logRecord);
+
+        public abstract void logFallback(String s);
+
         public abstract boolean isCurrentThreadPolyglotThread();
 
         public abstract Object getHostNull();

truffle/src/com.oracle.truffle.polyglot/src/com/oracle/truffle/polyglot/EngineAccessor.java

@@ -2023,6 +2023,21 @@ public String getFormatKind(LogRecord logRecord) {
             return PolyglotLoggers.getFormatKind(logRecord);
         }
 
+        @Override
+        public boolean isLogRecordCallerClassSet(LogRecord logRecord) {
+            return PolyglotLoggers.isCallerClassSet(logRecord);
+        }
+
+        @Override
+        public boolean isLogRecordCallerMethodSet(LogRecord logRecord) {
+            return PolyglotLoggers.isCallerMethodSet(logRecord);
+        }
+
+        @Override
+        public void logFallback(String s) {
+            PolyglotEngineImpl.logFallback(s);
+        }
+
         @Override
         public boolean isCurrentThreadPolyglotThread() {
             PolyglotThreadInfo info = PolyglotFastThreadLocals.getCurrentThread(null);

truffle/src/com.oracle.truffle.polyglot/src/com/oracle/truffle/polyglot/PolyglotEngineImpl.java

@@ -2516,7 +2516,7 @@ or use the default runtime (no JIT compilation of polyglot code) by passing -Dtr
      */
     static void logFallback(String message) {
         PrintStream err = System.err;
-        err.println(message);
+        err.print(message);
     }
 
     private static class MessageTransportProxy implements MessageTransport {

truffle/src/com.oracle.truffle.polyglot/src/com/oracle/truffle/polyglot/PolyglotLoggers.java

@@ -187,6 +187,14 @@ static String getFormatKind(LogRecord logRecord) {
         return (logRecord instanceof ImmutableLogRecord ? ((ImmutableLogRecord) logRecord).getFormatKind() : ImmutableLogRecord.FormatKind.DEFAULT).name();
     }
 
+    static boolean isCallerClassSet(LogRecord logRecord) {
+        return logRecord instanceof ImmutableLogRecord && ((ImmutableLogRecord) logRecord).isCallerClassSet();
+    }
+
+    static boolean isCallerMethodSet(LogRecord logRecord) {
+        return logRecord instanceof ImmutableLogRecord && ((ImmutableLogRecord) logRecord).isCallerMethodSet();
+    }
+
     static final class LoggerCache {
 
         static final LoggerCache DEFAULT = new LoggerCache(PolyglotLogHandler.INSTANCE, true, null, Collections.emptySet());
@@ -646,6 +654,8 @@ private static final class ImmutableLogRecord extends LogRecord {
 
         private static final long serialVersionUID = 1L;
         private final FormatKind formatKind;
+        private final boolean isCallerClassSet;
+        private final boolean isCallerMethodSet;
 
         enum FormatKind {
             RAW,
@@ -659,9 +669,15 @@ enum FormatKind {
             super.setLoggerName(loggerName);
             if (className != null) {
                 super.setSourceClassName(className);
+                this.isCallerClassSet = true;
+            } else {
+                this.isCallerClassSet = false;
             }
             if (methodName != null) {
                 super.setSourceMethodName(methodName);
+                this.isCallerMethodSet = true;
+            } else {
+                this.isCallerMethodSet = false;
             }
             Object[] copy = parameters;
             if (parameters != null && parameters.length > 0) {
@@ -741,6 +757,14 @@ FormatKind getFormatKind() {
             return formatKind;
         }
 
+        boolean isCallerClassSet() {
+            return isCallerClassSet;
+        }
+
+        public boolean isCallerMethodSet() {
+            return isCallerMethodSet;
+        }
+
         private static Object safeValue(final Object param) {
             if (param == null || EngineAccessor.EngineImpl.isPrimitive(param)) {
                 return param;