Fix linting, SL compilation tests, and signatures

Author: DSouzaM

compiler/src/jdk.graal.compiler.test/src/jdk/graal/compiler/truffle/test/BytecodeDSLPartialEvaluationTest.java

@@ -470,8 +470,8 @@ public void testUnwindTagInstrumentation() {
                 b.endSource();
             });
 
-            ProxyInstrument.findEnv(c).getInstrumenter().attachExecutionEventListener(SourceSectionFilter.newBuilder(). //
-                            tagIs(ExpressionTag.class).indexIn(text.indexOf("20"), 2).build(),
+            ProxyInstrument.findEnv(c).getInstrumenter().attachExecutionEventListener(SourceSectionFilter.newBuilder() //
+                            .tagIs(ExpressionTag.class).indexIn(text.indexOf("20"), 2).build(),
                             new ExecutionEventListener() {
 
                                 @Override

compiler/src/jdk.graal.compiler.test/src/jdk/graal/compiler/truffle/test/SLCompileBytecodeTestSuite.java

@@ -34,7 +34,7 @@
 @RunWith(SLTestRunner.class)
 @SLTestSuite(value = {"sl"}, options = {//
                 "engine.BackgroundCompilation", "false",
-                "engine.SingleTierCompilationThreshold", "10",
+                "engine.SingleTierCompilationThreshold", "20", // enough to transition to cached
                 "engine.MultiTier", "false",
                 "engine.CompileImmediately", "false",
                 "sl.UseBytecode", "true"

compiler/src/jdk.graal.compiler.test/src/jdk/graal/compiler/truffle/test/builtins/SLCallFunctionsWithBuiltin.java

@@ -35,6 +35,7 @@
 import com.oracle.truffle.api.strings.TruffleString;
 import com.oracle.truffle.sl.SLException;
 import com.oracle.truffle.sl.SLLanguage;
+import com.oracle.truffle.sl.nodes.SLRootNode;
 import com.oracle.truffle.sl.runtime.SLContext;
 import com.oracle.truffle.sl.runtime.SLFunction;
 import com.oracle.truffle.sl.runtime.SLNull;
@@ -67,7 +68,7 @@ public SLNull runTests(TruffleString startsWith, SLFunction harness,
     }
 
     private static Source getSource(SLFunction function) {
-        SourceSection section = function.getCallTarget().getRootNode().getSourceSection();
+        SourceSection section = ((SLRootNode) function.getCallTarget().getRootNode()).ensureSourceSection();
         if (section != null) {
             return section.getSource();
         }

truffle/src/com.oracle.truffle.api.bytecode.test/src/com/oracle/truffle/api/bytecode/test/basic_interpreter/BasicInterpreterTest.java

@@ -172,7 +172,6 @@ private static void assertInstructionEquals(Instruction actual, ExpectedInstruct
                     case BRANCH_PROFILE -> assertEquals((double) expectedArgument.value, actualArgument.asBranchProfile().getFrequency(), 0.0001d);
                     default -> throw new AssertionError(String.format("Testing arguments of kind %s not yet implemented", expectedArgument.kind));
                 }
-                ;
             }
         }
 

truffle/src/com.oracle.truffle.api.bytecode/snapshot.sigtest

@@ -291,6 +291,7 @@ CLSS public abstract interface !annotation com.oracle.truffle.api.bytecode.Gener
 intf java.lang.annotation.Annotation
 meth public abstract !hasdefault boolean allowUnsafe()
 meth public abstract !hasdefault boolean enableBlockScoping()
+meth public abstract !hasdefault boolean enableBytecodeDebugListener()
 meth public abstract !hasdefault boolean enableQuickening()
 meth public abstract !hasdefault boolean enableRootBodyTagging()
 meth public abstract !hasdefault boolean enableRootTagging()
@@ -590,6 +591,10 @@ CLSS public abstract interface !annotation com.oracle.truffle.api.bytecode.Varia
 intf java.lang.annotation.Annotation
 
 CLSS public abstract interface com.oracle.truffle.api.bytecode.debug.BytecodeDebugListener
+meth public void afterInstructionExecute(com.oracle.truffle.api.bytecode.Instruction,java.lang.Throwable)
+meth public void afterRootExecute(com.oracle.truffle.api.bytecode.Instruction,java.lang.Object,java.lang.Throwable)
+meth public void beforeInstructionExecute(com.oracle.truffle.api.bytecode.Instruction)
+meth public void beforeRootExecute(com.oracle.truffle.api.bytecode.Instruction)
 meth public void onBytecodeStackTransition(com.oracle.truffle.api.bytecode.Instruction,com.oracle.truffle.api.bytecode.Instruction)
 meth public void onInvalidateInstruction(com.oracle.truffle.api.bytecode.Instruction,com.oracle.truffle.api.bytecode.Instruction)
 meth public void onQuicken(com.oracle.truffle.api.bytecode.Instruction,com.oracle.truffle.api.bytecode.Instruction)

truffle/src/com.oracle.truffle.api.bytecode/src/com/oracle/truffle/api/bytecode/debug/BytecodeDebugListener.java

@@ -40,7 +40,6 @@
  */
 package com.oracle.truffle.api.bytecode.debug;
 
-import com.oracle.truffle.api.bytecode.BytecodeDSLAccess;
 import com.oracle.truffle.api.bytecode.GenerateBytecode;
 import com.oracle.truffle.api.bytecode.Instruction;
 

truffle/src/com.oracle.truffle.sl/src/com/oracle/truffle/sl/parser/SLBytecodeParser.java

@@ -428,14 +428,7 @@ public Void visitLogic_term(Logic_termContext ctx) {
 
     private void emitShortCircuitOperands(List<? extends ParseTree> operands) {
         for (int i = 0; i < operands.size(); i++) {
-            if (i == operands.size() - 1) {
-                // Short circuit operations don't convert the last operand to a boolean.
-                b.beginSLToBoolean();
-                visit(operands.get(i));
-                b.endSLToBoolean();
-            } else {
-                visit(operands.get(i));
-            }
+            visit(operands.get(i));
         }
     }